Muted categories showing for anonymous users

pfaffman · August 30, 2021, 2:32pm

I have a site with a bunch of muted categories. These categories and topics are hidden when visiting as a logged-in user, but anonymous users see these categories (on /categories) and topics from those appear in /latest.

EDIT: FWIW:

      <meta name="generator" content="Discourse 2.8.0.beta4 - https://github.com/discourse/discourse version b673fee9464e823de3c3423a5f8c45732896b429">

sam · August 31, 2021, 5:39am

@vinothkannans I vaguely recall we dealt with this issue in the past, do you remember?

vinothkannans · August 31, 2021, 6:07am

Yes, we pushed a fix for that. I will check the issue again.

pfaffman · September 4, 2021, 5:06pm

Just checking on this. I upgraded to the current beta6 and the problem persists.

vinothkannans · September 5, 2021, 1:05pm

@pfaffman I’m unable to reproduce this issue both in my development environment and personal site. It is working properly for me.

On /categories page, if a muted category has subcategories which are not muted then it will appear to display the list of sub-categories.

here is the old fix

pfaffman · September 7, 2021, 3:09pm

Thanks for checking. I’m pretty stumped, then.

My best guess is that it’s something with the question/answer plugin, thoug disabling it didn’t change anything. I don’t see how a theme component could change that.

pfaffman · September 15, 2021, 4:58pm

So here’s the issue.

If mute_all_categories_by_default is set, then it ignores the muted categories list. It’s giving me all categories if mute_all_categories_by_default, but obeys the default_categories_muted if it’s not.

github.com

discourse/discourse/blob/main/lib/topic_query.rb#L836

    
      
            list = list
              .references("cu")
              .joins("LEFT JOIN category_users ON category_users.category_id = topics.category_id AND category_users.user_id = #{user.id}")
              .where("topics.category_id = :category_id
                      OR COALESCE(category_users.notification_level, :default) <> :muted
                      OR tu.notification_level > :regular",
                      category_id: category_id || -1,
                      default: CategoryUser.default_notification_level,
                      muted: CategoryUser.notification_levels[:muted],
                      regular: TopicUser.notification_levels[:regular])
          elsif SiteSetting.mute_all_categories_by_default
            category_ids = [
              SiteSetting.default_categories_watching.split("|"),
              SiteSetting.default_categories_tracking.split("|"),
              SiteSetting.default_categories_watching_first_post.split("|"),
              SiteSetting.default_categories_regular.split("|")
            ].flatten.map(&:to_i)
            category_ids << category_id if category_id.present? && category_ids.exclude?(category_id)
          
          
  list = list.where("topics.category_id IN (?)", category_ids) if category_ids.present?
          else

This seems like a bug, to ignore the muted categories, or maybe it doesn’t make any sense to have muted categories if all categories are muted by default. But it would seem like if all categories are muted by default and there are no watched categories then it should show nothing?

Topic		Replies	Views
Mute `default_categories_muted` for anonymous users Feature	2	621	November 20, 2019
Mute tag in settings seems to be broken? The muted tag topics still show up in the /latest Support	17	1095	August 27, 2020
Muted categories appear in Categories page UX	16	2210	November 17, 2021
Muted Categories are Visible on Mobile Feature	7	1100	March 17, 2020
Hide Muted Categories Theme component official , hide-muted-categories	18	3072	December 26, 2023

Muted categories showing for anonymous users

Related topics