الفئات المكتومة تظهر للمستخدمين المجهولين

pfaffman · 30 أغسطس 2021، 2:32م

I have a site with a bunch of muted categories. These categories and topics are hidden when visiting as a logged-in user, but anonymous users see these categories (on /categories) and topics from those appear in /latest.

EDIT: FWIW:

      <meta name="generator" content="Discourse 2.8.0.beta4 - https://github.com/discourse/discourse version b673fee9464e823de3c3423a5f8c45732896b429">

sam · 31 أغسطس 2021، 5:39ص

@vinothkannans I vaguely recall we dealt with this issue in the past, do you remember?

vinothkannans · 31 أغسطس 2021، 6:07ص

Yes, we pushed a fix for that. I will check the issue again.

pfaffman · 4 سبتمبر 2021، 5:06م

Just checking on this. I upgraded to the current beta6 and the problem persists.

vinothkannans · 5 سبتمبر 2021، 1:05م

@pfaffman I’m unable to reproduce this issue both in my development environment and personal site. It is working properly for me.

On /categories page, if a muted category has subcategories which are not muted then it will appear to display the list of sub-categories.

here is the old fix

https://github.com/discourse/discourse/commit/57bbcf4c5db4a99d2e01324ee2f172b741fcc5f9

pfaffman · 7 سبتمبر 2021، 3:09م

Thanks for checking. I’m pretty stumped, then.

My best guess is that it’s something with the question/answer plugin, thoug disabling it didn’t change anything. I don’t see how a theme component could change that.

pfaffman · 15 سبتمبر 2021، 4:58م

So here’s the issue.

If mute_all_categories_by_default is set, then it ignores the muted categories list. It’s giving me all categories if mute_all_categories_by_default, but obeys the default_categories_muted if it’s not.

github.com

discourse/discourse/blob/main/lib/topic_query.rb#L836

    
      
            list = list
              .references("cu")
              .joins("LEFT JOIN category_users ON category_users.category_id = topics.category_id AND category_users.user_id = #{user.id}")
              .where("topics.category_id = :category_id
                      OR COALESCE(category_users.notification_level, :default) <> :muted
                      OR tu.notification_level > :regular",
                      category_id: category_id || -1,
                      default: CategoryUser.default_notification_level,
                      muted: CategoryUser.notification_levels[:muted],
                      regular: TopicUser.notification_levels[:regular])
          elsif SiteSetting.mute_all_categories_by_default
            category_ids = [
              SiteSetting.default_categories_watching.split("|"),
              SiteSetting.default_categories_tracking.split("|"),
              SiteSetting.default_categories_watching_first_post.split("|"),
              SiteSetting.default_categories_regular.split("|")
            ].flatten.map(&:to_i)
            category_ids << category_id if category_id.present? && category_ids.exclude?(category_id)
          
          
  list = list.where("topics.category_id IN (?)", category_ids) if category_ids.present?
          else

This seems like a bug, to ignore the muted categories, or maybe it doesn’t make any sense to have muted categories if all categories are muted by default. But it would seem like if all categories are muted by default and there are no watched categories then it should show nothing?

الموضوع		الردود	مرات العرض
Muted categories appear in Categories page UX	16	2232	17 نوفمبر 2021
Muted categories behavior for anon users? Support	0	110	10 مايو 2024
Mute `default_categories_muted` for anonymous users Feature	2	638	20 نوفمبر 2019
Filter view for muted categories Feature	7	1513	4 أغسطس 2020
Muted categories are too atomic Feature	14	4705	26 أبريل 2016

الفئات المكتومة تظهر للمستخدمين المجهولين

الموضوعات ذات الصلة