Number rating poll allows step (width) "0"

pr-welcome

(Ronja S) #1

Hey there,

I hope, this is a unknown issue. Ich couldn’t find this here and it’s still in the sandbox.
It’s possible that the user can choose step “0” in the number rating poll GUI. When you’re doing that, it is possible (depends on browser and so on), that your device (PC) will lock up instantly (the cause is obviously, without seeing the code - it does not terminate?..). So you have to force shut-down and reboot. I think this option should be therefore forbidden. In the best case even the manual insert should be forbidden, too (note/warning, when you try to send post).

Thank you!
Ronja


(Ronja S) #4

=>
(poll type=number min=1 max=30 step=0]
[/poll]

Sorry… language… stepwidth instead of “step”?


(Joshua Rosenfeld) #5

Oh, my bad. Misunderstood. Yeah, that’s not good.


(Michael Howell) #6

(Eric Berry) #7

The browser is crashing b/c of the preview. I will get a PR in to resolve this.


(Eric Berry) #8

@codinghorror PR is ready for review :+1:t2:


(Eric Berry) #9

This PR has been merged :raised_hands:t2:


(Ronja S) #10

Thank you! Im looking forward to report an issue again… great first experience.


(Gerhard Schlager) #11

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.