"Open all external links in new tab" doesn't work from reply context

It seems to be isolated only to links to other Discourse instances though.

Repro steps, with “Open external links in new tab” enabled in options:

  1. Reply to a post containing a link to another Discourse instance (not a oneboxed post)
  2. Click the “Reply to” indicator.
  3. Click on the link
  • external links to non-Discourse sites seem to work fine
  • links to other Discourse instances open in same tab
  • EXCEPTION: http://what.thedailywtf.com behaves correctly

Reproduced here in a PM chain.

7 Likes

Even this didn’t work for me.

1 Like

I just had this problem with a link (oneboxed) to here.

1 Like

Just to clarify, this is in fact broken:

The oneboxes are good, the non oneboxed stuff is bust.

1 Like

Fixed per:

https://github.com/discourse/discourse/commit/9d113bd536a0c5bf0dd2819edbd6783d6693928e

Quite severe, all link tracking was broken for any expanded posts (above or below)

3 Likes