Orientation fix missing in latest stable

bug
1

Saturday morning is always a good moment to research weird problems.
I suddenly see things that I’ve overlooked for a long time.

The image orientation fix seems to be missing in the stable branch.

Can you please, please backport it for 1.9.3 ?

Master:
https://github.com/discourse/discourse/blob/master/lib/upload_creator.rb#L44-L51

Stable:
https://github.com/discourse/discourse/blob/stable/lib/upload_creator.rb#L44-L50

2 Likes
2

Sure @zogstrip can you take a look?

2 Likes
4

I did a diff between stable 1.9.0 and tests-passed 2.0 beta1, which should be pretty much the same, and I found three more differences which should not be there.

https://github.com/discourse/discourse/blob/stable/lib/validators/upload_url_validator.rb#L6
https://github.com/discourse/discourse/blob/master/lib/validators/upload_url_validator.rb#L6

https://github.com/discourse/discourse/blame/stable/lib/final_destination.rb#L208-L223
https://github.com/discourse/discourse/blame/v2.0.0.beta1/lib/final_destination.rb#L208-L218

https://github.com/discourse/discourse/blame/stable/app/assets/javascripts/discourse/templates/components/group-membership-button.hbs#L28-L31

1 Like
5

@zogstrip @neil do you have any plans to merge these changes back in to stable ?

6

Yup. Topic isn’t closed and still is assigned :wink: Just haven’t got a chance to do it yet.

4 Likes
7

Would it be possible to merge the image rotation bugfix back into stable before Discourse 2.0 stable is being released? It’s only a single line in upload_creator.rb that is still causing a lot of headaches.

1 Like
8

Sorry for the delay. It’s now backported :banana:

https://github.com/discourse/discourse/commit/82148a168f6dfe051c22faeeb56ad2e49a71d59a

5 Likes
9

This topic was automatically closed after 3 hours. New replies are no longer allowed.