Orientation fix missing in latest stable


(Richard - DiscourseHosting.com) #1

Saturday morning is always a good moment to research weird problems.
I suddenly see things that I’ve overlooked for a long time.

The image orientation fix seems to be missing in the stable branch.

Can you please, please backport it for 1.9.3 ?

Master:

Stable:


(Jeff Atwood) #2

Sure @zogstrip can you take a look?


(Richard - DiscourseHosting.com) #4

I did a diff between stable 1.9.0 and tests-passed 2.0 beta1, which should be pretty much the same, and I found three more differences which should not be there.




(Richard - DiscourseHosting.com) #5

@zogstrip @neil do you have any plans to merge these changes back in to stable ?


(Régis Hanol) #6

Yup. Topic isn’t closed and still is assigned :wink: Just haven’t got a chance to do it yet.


Stable is well... broken
(Richard - DiscourseHosting.com) #7

Would it be possible to merge the image rotation bugfix back into stable before Discourse 2.0 stable is being released? It’s only a single line in upload_creator.rb that is still causing a lot of headaches.


(Régis Hanol) #8

Sorry for the delay. It’s now backported :banana:


(Régis Hanol) #9

This topic was automatically closed after 3 hours. New replies are no longer allowed.