Stable is well... broken

Hey guys,

We were just deploying a few new servers and my conclusion is that the stable branch is lacking a few backports of crucial bug fixes. I don’t have a lot of experience with cherry picking but I can point out the issues in question.

It’s the orientation fix and the backup restore fix.

Any chance of getting those back into the stable branch soon? Anything we can do to help here?

6 Likes

Not sure maybe @tgxworld can see what he thinks.

5 Likes

The fixes for restoring backups taken with the new pg_dump clients have been back-ported into stable.

4 Likes

A post was merged into an existing topic: Help … rebuild app failed

Thanks for backporting these fixes!

However, it does not work. I have been testing this and restoring the backup is still failing.
I was able to nail it down to this migration that was not backported but which is crucial:

https://github.com/discourse/discourse/blob/10d6101eae2f613f8489754144feaff2324727c5/db/migrate/20180308071922_drop_raise_read_only_function.rb

EDIT I have just double checked and when I add this migration, backup/restore is functioning correctly again.

13 Likes

Backported as well, thanks for digging into this :+1:

15 Likes

And here is the final confirmation that backup/restores are working correctly on stable again!

9 Likes

Thank you for helping us work through this :pray:

4 Likes