I just flagged a topic here on Meta as “something else”. When you do so, a private conversation between you and moderators is created. Under the discussion, there are ‘Suggested messages’ which I am not part of. I see their titles and participants. However when I click a discussion, I get a connection error so I cannot read them which is good. Under normal messages there are messages from my own messages as it should be.
Looks like the joins are not unnecessary after all
https://github.com/discourse/discourse/commit/d9714c21c80ab3b8ff68a5520d8086aa8e91588f
6 Likes
Fixed in
https://github.com/discourse/discourse/commit/1a9762a9c0e830590760a63b9ddb11f17b135921
This was actually due to a combination of https://github.com/discourse/discourse/commit/f3fadf41b7d723265094bb90203226941defce58 and https://github.com/discourse/discourse/commit/28148197d6467cdc7469409f961c00d4e32f4c41
Added test cases to guard against regression.
Thanks for reporting @rizka
11 Likes