This is incredibly well timed for me, Iāve been afk for the past 3 months or so preparing for and taking exams, and I just finished this week!
So this looks like the perfect opportunity (and incentive) to familiarise myself with the changes which have happened while Iāve been away. I may be a little rusty, given all the time spent recently staring at textbooks rather than computer screens, but now that exams are over I have all the time in the world to spend on it. How does that sound?
If you agree to take the challenge, can you send me a private message with your email address?
If you do the job, we will probably finance another 500ā¬ bounty for the other github issues, which are mostly enhancements. In fact, we want to give enough incentives for someone to step up as a maintainer for this plugin which we think can be really useful.
@bzg do you need backwards compatibility with versions of Discourse which donāt have plugin api support, because Iāve run into a little problem trying to achieve that:
Otherwise, Iām mostly done. I still need to blow the cobwebs out of my docker environment to test the plugin in a production environment, and to ensure the functionality now matches the functionality before, but once Iāve done that I think Iām all done and Iāll send a pull request your way.
No, we donāt need such backward compatibility. Itās better to have it, of course, but this is not required for this bounty. The Discourse we run is >1.6.
(EDIT: because you forget to state the obvious when itās so close to bedtime)
Iāve finally got round to submitting the pull request. Sorry about the unexplained delay, I had been trying to get docker to work with a (now ancient) version of Discourse which the plugin in its current state can run on, but I couldnāt wrap my head around it. And then I ran out of time in the week.
So, hopefully, it works as it did before. From reading the code before it works as I would expect that code to work, but youāll have to let me know.
Also, are you running beta or tests-passed? I ask because in the tests-passed branch (and the next beta release) the markdown engine has been moved to a module which needs to be imported, which breaks the code as it is in those branches.
Itās simple to import the module, but then it wonāt work in the current beta and stable branches. It would be possible to conditionally require it, but that gets a bit messy.
thanks a lot for your work! And no problem at all with the delay, anytime in July is perfectly fine.
We are on the tests-passed branch. I just performed an upgrade and we are now on 86b3de51.
As I understand it, I would need to update our app.yml file to download the markdown module, is that so?
I want to keep the plugin as straightforward as possible, with no tricky requirement - let me know whatās the best route to take, and then Iāll merge your PR and test it on the server.
Not quite, itās a file a file in the plugin which needs to import the module. Iāve pushed a commit which does this, so now it should work on tests-passed (it does locally).