Pinch zoom crashes on iOS (Graceful theme)

Bug
1

iOS 18.2 pinch zooming mostly crashes. Cannot zoom to images but also anything in a topic.

UPDATE: It seems to happen when you pinch zoom and then you “rough” swipe with one finger (e.g. to move all the way down) when zoomed in. Or zoom out. You must zoom into a content. When you zoom e.g. on buttons, it might not crash.

4 Likes
3

Crashes like this are likely browser bugs, that said I have alerted the team in case they have any ideas.

2 Likes
5

I haven’t been able to reproduce this on iOS 18.2.1.

Is anyone else seeing the same problem?

1 Like
6

OK, I upgraded to 18.2.1 and after few tests I cannot reproduce again.

2 Likes
7

It happened again (iOS 18.2.1). If I zoom in and then I zoom out but much more than 1:1, I can reproduce the crash.

4 Likes
9

Thanks @tvavrda - a few of us on the team have been able to reproduce the same issue, and are looking into it :eyes:

3 Likes
12

It is certainly a browser bug, but @pmusaraj just merged a fix that appears to fix it in our testing.

Can you confirm all is working after you update?

3 Likes
13

It works now on the default theme. But I have GitHub - discourse/graceful installed and there it still crashes :man_shrugging:

1 Like
14

@pmusaraj / @awesomerobot I wonder if graceful has some elements with -1 z-index?

1 Like
15

It does but removing it did not help. Or maybe I did something wrong.

2 Likes
16

We will have a look will keep the bug open for now.

(I tagged it for clarity on what the bug has evolved to)

3 Likes
17

This should fix it: FIX: Prevent bug with pinch zooming in Safari iOS by pmusaraj · Pull Request #40 · discourse/graceful · GitHub

I’m going to file this upstream tomorrow (or see if somebody else filed it), this very much feels like a recent regression in Safari on iOS, this code has been in the Graceful theme for a long time.

5 Likes
19

The fix above is now merged, looks good here on meta, hope it’s the same on your instance @tvavrda, thanks for the report!

I tried to repro this on a simple codepen so I could report upstream, but I can’t repro. Something else on our app might contribute to the problem, trouble is, not sure how to track down what else is a contributing factor.

2 Likes
21

Seems good so far! I had a customized theme so I just reproduced your modifications and it looks good. I can finally look at images from my phone! Thanks for the support :heart:

3 Likes