Polls causing issues

Bug
,
1

I’ve just noticed an issue with topics that contain a poll. This is on 3.3.0.beta4-dev (a30a861546). Many interactions break on what seems to be the entire topic for some topics. It seems to only happen if the topic contains a poll and the poll hasn’t been voted in by the viewing user. Some of the specific things I noticed:

  • Polls do not have the button for the moderation menu that lets you do things like close the poll or export results
  • The admin actions menu for posts doesn’t appear when the button is pressed
  • The admin actions menu for the topic does appear, but doesn’t go away if you tried to open a post menu first
  • Clicking on user profile pictures does nothing if you tried to open a post admin actions menu first

These issues all go away on topics without polls and if you disable the poll enabled site setting or enable safe mode with ?safe_mode=no_plugins. The following exception appears when loading the site:

Uncaught (in promise) TypeError: e[b].getValue(...) is not a function
    at Object.evaluate (runtime.js:1668:1)
    at Object.evaluate (runtime.js:1052:1)
    at It.evaluateSyscall (runtime.js:4204:1)
    at It.evaluateInner (runtime.js:4175:1)
    at It.evaluateOuter (runtime.js:4168:1)
    at Wt.next (runtime.js:4999:1)
    at Wt._execute (runtime.js:4986:1)
    at Wt.execute (runtime.js:4979:1)
    at Ut.handleException (runtime.js:4313:1)
    at Vt.handleException (runtime.js:4521:1)
    at Dt.throw (runtime.js:4260:1)
    at Ve.evaluate (runtime.js:2106:1)
    at Dt._execute (runtime.js:4247:1)
    at Dt.execute (runtime.js:4232:1)
    at qt.rerender (runtime.js:4547:1)
    at hr.render (index.js:4674:1)
    at index.js:4934:1
    at Nt (runtime.js:4080:1)
    at gr._renderRoots (index.js:4916:1)
    at gr._renderRootsTransaction (index.js:4960:1)
    at gr._revalidate (index.js:4992:1)
    at invoke (backburner.js.js:280:1)
    at h.flush (backburner.js.js:197:1)
    at p.flush (backburner.js.js:358:1)
    at B._end (backburner.js.js:798:1)
    at B.end (backburner.js.js:589:1)
    at B._run (backburner.js.js:842:1)
    at B._join (backburner.js.js:819:1)
    at B.join (backburner.js.js:629:1)
    at Array.<anonymous> (index.js:4765:1)
    at B._trigger (backburner.js.js:896:1)
    at B._end (backburner.js.js:811:1)
    at B._boundAutorunEnd (backburner.js.js:523:1)
3 Likes
2

Thanks for the report. I’m looking into this and will aim to PR a fix asap.

3 Likes
3

PR raised:

9 Likes
4

@Chief-Engineer this fix has now ticked-through to tests-passed. I performed a Production checkout and hopefully you will be good to go now.

Please let me know if you find any more issues in Polls.

Please note that option text wrapping formatting behaviour is a known issue and a proposed fix has already been raised as a PR which is currently pending review:

6 Likes
5

Thanks for the seriously quick fix @merefield :smiley:

1 Like
6

All polls with images in them have broken :thinking:

(both old and new)

They display ok in the composer window:

Screenshot 2024-07-05 at 14.47.50
Screenshot 2024-07-05 at 14.47.501920×1264 207 KB

But are very broken when viewing the topic normally:

Screenshot 2024-07-05 at 14.47.24
Screenshot 2024-07-05 at 14.47.241920×1545 177 KB

Looks like it’s also broken here on Meta too:

Images polls - #2 by Arkshine

Is this related?

Or a new issue?

4 Likes
7

Very interesting … is this a documented feature? Can you point me to that?

… not a single test is failing, were these supported by accident?

Polls was very recently moved to Glimmer so there’s been a lot of change to the front end (more or less a rewrite of the FE)

But this migration only took place this week, and not back in May so I don’t think this migration was the first appearance of that issue.

I’ll take a look when I have time to see if it’s straightforward to add support.

3 Likes
8

It seems there are some polls in this documentation topic that are broken now. The dates, for example, are not displayed correctly.

3 Likes
9

That topic makes it look like image polls were at least somewhat officially supported for a while:

4 Likes
10

Sure, thanks for showing me that.

Let’s not debate this further, I’ll try to add back support … thanks for your patience.

7 Likes
11

fix has been merged

2 Likes