On our managed discourse.org hosting, weâll be doing a staged rollout of the flag over the next couple of months.
With the holidays coming fast, no deprecation will be fixed on my side before the end of January, would you mind getting us a more precise time-frame?
I know my own personal project priorities have nothing to do with Discourse - but in the corporate world we cannot move as fast as we want
Anyway, looks like I donât have a lot of things to fix, only 4 deprec:
[THEME 2 'XXX Theme'] Deprecation notice: controller:navigation/category no longer exists, and this shim will eventually be removed. To fetch information about the current discovery route, use the discovery service instead. [deprecation id: discourse.navigation-category-controller] deprecated.js:54:12
[THEME 2 'XXX Theme'] Deprecation notice: Defining connector classes via registerConnectorClass is deprecated. See https://meta.discourse.org/t/32727 for more modern patterns. [deprecation id: discourse.register-connector-class-legacy] 2 deprecated.js:54:12
DEPRECATION: [THEME 2 'XXX Theme'] Function prototype extensions have been deprecated, please migrate from function(){}.property('bar') to computed('bar', function() {}). [deprecation id: function-prototype-extensions.property] See https://deprecations.emberjs.com/v3.x#toc_function-prototype-extensions-property for more details. deprecate-shim.js:33
[THEME 2 'XXX Theme'] "model:user" has already been initialized and registered as a singleton. Move the modifyClass call earlier in the boot process for changes to take effect. https://meta.discourse.org/t/262064 plugin-api.js:220:14
With the holidays approaching, I think itâs safe to say that we wonât be rolling this out to the standard/business tiers of our hosting before the end of the year. Beyond that, we donât have any concrete dates right now.
Right now weâre collecting data about how widespread the issues are, and working on strategies to warn admins and help them resolve things. Following the instructions in the announcement here will help, but we canât rely on everyone to be keeping track of these announcements on Meta.
Thatâs great! And just looking at these, the only critical one for the ember upgrade is the âFunction prototype extensionsâ one (but of course, the others will eventually become critical as well, so itâs still worth resolving them)
Thanks David I just make a test ride yesterday. Seems everything works great except 2 plugins I use. Fingerprint plugin admin page is empty and Locations plugin user map isnât load. There is no error in console or /logs. That is a good news I can revert it and there is a lot of time to fix these before itâs be a part of core. Thanks for you work
I havenât had time to look yet, but will do soon! My time is spread across a lot of repos and Locations had a big slice of me in the last couple of months, and clearly requires a little bit more
Thanks David, that seems works great But I have noticed a little odd thing, after I updated now Discourse in admin and the console log Ember change back to
I double checked the app.yml and the EMBER_VERSION: 5 still there. But it seems the admin upgrade is reverted the Ember version. I checked and the Location map is also loads fine. So the console log is correct and itâs really reverts.
I can confirm it works. After I rebuild it is on Ember 5.4.0 again. I made an admin upgrade after rebuild and the Ember version is still the 5.4.0. Thanks
Iâve updated the first post here with a couple of new pieces of information:
We now have an approximate timeline. We intend to make Ember 5 the default in tests-passed next week. On our hosting, itâll be enabled for âstandard tierâ sites starting from 15th January, and then Business tier sites starting 22nd January.
Weâve introduced a new UI warning banner to provide a more prominent warning to admins about incompatible themes/plugins in advance of the upgrade. This feature was merged today in 3.2.0.beta4-dev, and is live across our standard/business hosting tiers.
The site I referenced is a free site. I am so use to not seeing free sites broken out and instead typically falling under the rules of standard that I should have looked closer.
Hey @xJack, unfortunately the system canât always identify the source of the problem automatically. There should be a little more information in the browser developer console per
Another useful piece of information would be to know whether the banner is always there, or whether it only appears after you visit certain pages or take certain actions?
If your site is on our managed discourse.org hosting and youâd like a hand with the investigation, please do feel free to contact our support team via team@discourse.org
The default Ember version has now been updated in main/tests-passed. That means that local development environments, CI, and self-hosted sites will be using Ember 5 unless they temporarily opt-out via the EMBER_VERSION=3 flag