Proofread breaks quotes

Bug
, ,
1

Just FYI. The proofread breaks quotes. This has that way a while now.

This image depicts a screenshot of a resolution suggestion view in an editing tool, highlighting specific text edits for a post with a quoted section. (Captioned by AI)
This image depicts a screenshot of a resolution suggestion view in an editing tool, highlighting specific text edits for a post with a quoted section. (Captioned by AI)1210Ă—1297 169 KB

1 Like
2

Doesn’t really break the quote, only the preview visualization.

I’d say this, plus the the animated diff we have on the roadmap, means we should move to doing a diff without the cooking part of it.

What do y’all think @awesomerobot @keegan ?

5 Likes
3

Just to add to this…

We recently updated Discourse, and from what I recall, the plugin wouldn’t try to proofread quoted text (as it shouldn’t because technically it’s not really quoted anymore if it does).

Below is a screenshot…

The image shows a suggested edit notification for a post in a format where numbers are incorrectly spelled as letters, prompting a correction from "ne-number" to "number." (Captioned by AI)
The image shows a suggested edit notification for a post in a format where numbers are incorrectly spelled as letters, prompting a correction from "ne-number" to "number." (Captioned by AI)1238Ă—1012 78.5 KB

5

@keegan just rolled out a new implementation, the diff is now applied to markdown and streamed :heart_eyes:

It works great for this case and even handles fixing typos in quotes :slight_smile:

The image shows a "Suggested edits" dialog box where a user is commenting on a quote implementation for markdown and streamedstreamed, with options to confirm or discard the change. (Captioned by AI)
The image shows a "Suggested edits" dialog box where a user is commenting on a quote implementation for markdown and streamedstreamed, with options to confirm or discard the change. (Captioned by AI)825Ă—539 63.7 KB

2 Likes
6

I’m here because I don’t think that proofread should fix quoted material (it is not quoted if it is “fixed”)

Is there a way to request a switch to not touch quoted material?

Btw: Great job on the recent upgrade and making so many plugins including AI as a standard. I’m self-hosted and I had to remove a few plugins in order to upgrade which had them as standard. (thanks for seamless experience preserving our emojis). I’m happy that everyone else who does not know how to add plugins now gets the full experience. I just set up the AI experience yesterday and it is good.

7

I think we can do something here. It is somewhat tricky cause we need to hoist out content and then re-insert it into the post.

I certainly consider this a bug, will put a pr-welcome on this for now, I may get to it, but it is a bit tricky. The server side needs to partially parse the markdown, remove the quotes, give to proofreader and then add them back in, this may end up resulting in the proofreader getting an incoherent thing to proof read.

Tricky problem.

8

We did some prompt engineering, but technically, this is still breaking a quote

image
image771Ă—471 41.7 KB

9

Is proofreading quotes actually a real issue :thinking: After all, the error should have been fixed by the quoted user in the first place. Anyway, as long as the AI doesn’t change the context itself — and it does/did make such changes sometimes.

I almost hate to say this out loud, but worrying about changes per se sounds almost like code-based behavior where the most horrible thing that can happen is if x=y changes to x=1 even when the latter one is true too :joy:

But sure. If a quote can stay untouched, just like a code block should be left alone, that would be nice or even great. But is it such a big thing that anybody should use a lot of paid hours to fix it?

Another sure. That is just my opinion and I know there are situations where a quote should be a 1:1 copy.

1 Like