This is looking fantastic to me! I say we live with this till next Wednesday on meta. Then… a PR is absolutely welcome to bring this in as is in to core and kill the component. @codinghorror also loves this.
I do not mind the slight misalignment due to the ear, it looks fine to me and this stuff usually bugs me a lot.
I love the iteration speed here, the quality and the thought you put into it!
At this point the only “nit” I have left picking is that on absolute initial load stuff jumps a bit and you get a scrollbar for a few fractions of a second. very minor and I am sure a bit of css can cure it.
A bug - clicking Log Out takes you to your user summary, unable to successfully sign out:
I can confirm @nexo’s bug report here on meta.
On my sites I don’t seem to have this
person tobiaseigen menu yet - clicking on it just takes me to my activity page.
Thanks, I just pushed a fix! Updating the theme component should do it.
Could you try updating Discourse? You will need to be on latest Discourse for the person / profile quick access tab, specifically this commit from two days ago.
That was quick work - the fix works!
Arrgh. I should have known to try that first. But yes, updating discourse worked and now this functionality works on my site.
How about a custom links setting in the theme component? I can see this being super useful for every site with SSO to provide dashboard links relevant only to logged in members. On my site I just replaced a custom header with the Brand header theme component which is working great, and future proof too with no customizations! Now would also like to be able to add an “Edit profile” linking to wordpress that is also future proof.
You may make all notifications under tabs scrollable. It’s redirecting to another page even for a quick peek.
Really like the new design! With the new bookmarks tab maybe it’s worth having some sort of indicator for the author of the post or some other identifying info? Maybe before it in plain text in a similar way to how names in other notifications/messages look? Would help when you have a bunch of bookmarks from the same topic.
Yea that makes sense! I have pushed an update for this, thanks!
I am actually preparing a PR to fold this into core right now. After it’s included in core, I imagine it shouldn’t be too hard to have another theme component that adds custom links there!
It works just fine (made an update). Very comfortably!
Many thanks to everyone!
This is now in core as of the update I made this morning, so the theme component must be removed to avoid duplicate tabs and weirdness showing up in the menu. Once removed and browser hard refresh all is well. Nice work - this is a fabulous improvement to discourse.
Thanks @Stranik @tobiaseigen! The PR was only just merged around the time you updated!
Thanks for the heads-up! I am going to deprecate the theme component with an update (i.e. wipe it out + some console messages).
I originally thought about keeping it so instances on
stable can also try out the feature, but I realized it depends on some other new changes in core, so it essentially only works on
I’m really excited this is finally merged!
That would be a waste
That theme component is a fantastic example of how to wire things up correctly in the context of themes.
Since we just released a new beta, you can use that to nullify the component based on Discourse version via the
maximum_discourse_version. Check this out Adding metadata to a theme
Wow TIL thanks! Tried this out locally and it is so cool!
Wow! This is and looks amazing! Well done.
Amazing work, Kyle!
I noticed a minor issue here, it looks like the Messages and Assigned tabs are having trouble rendering every row with single / double quotes. I’m seeing this on Firefox, Windows if that helps.
Bookmarks & Notifications
These two tabs can render quotes just fine
Nice catch! I just submitted a PR to fix this in core (another will follow shortly for assignment).
Special characters are escaped before being rendered, however,
fancy_title is already escaped. Escaping it again would print the HTML entity as-is, e.g.
" instead of the desired
Should the group inboxes also be under the PM tab? I keep expecting them to be there.
That would not be my expectation, no.
To clarify, I would expect that tab to just be messages directed specifically to me.
Yeah I guess that’s a logical distinction… the disconnect for me might be that all the messages are under the envelope icon on my profile, but not in my notification menu (the sidebar under messages on profiles does split them out, so the UI is just different overall).