Quick Messages Plugin

I will add support for this soon.

hm, I’m not sure about this one. What’s the utility of removing this icon?

I signed up as angus on your forum. Send me a message.

I’ve added support for the Who’s Online plugin.

https://github.com/angusmcleod/discourse-quick-messages/commit/348e1ac6789c2c1666c26db17c0f9c0792818fad

Added.

https://github.com/angusmcleod/discourse-quick-messages/commit/51352c305c573518fad7f48ab1c0f720f6cb396f

I’ve added a site setting to let you change the icon: quick message icon.

https://github.com/angusmcleod/discourse-quick-messages/commit/200fefbf842ea2842aa5ac0e84a2f4f99f0b15ac

Yeah, makes sense. I’ll add it soonish.

7 Likes

Thank you so much for the support, and pardon my dumb question, but those github links that you placed in your response, not to install Quick Messages, do I have to copy the the Git clone link and install it on my website like a normal plugin? Like if I wanted to have quick messages display if a recipient is online, etc.?

1 Like

If you have Quick Messages installed already (i.e. you’ve been using it on your site), just go to yoursite.com/admin/upgrade and upgrade Quick Messages.

If you don’t have Quick Messages installed yet, you can follow this guide to install it.

2 Likes

It still does not show if the person/recipient is online or not :frowning:

It seems to be working on my sandbox.

Screenshot%20at%20Jun%2006%2021-16-19

Do you have Who’s Online installed and is Quick Messages is up-to-date?

Where’s your site?

1 Like

@modius Thanks for the test message, it clarified what was wrong.

Your issue is a conflict between the Checklist Plugin and this plugin.

This will fix it:

https://github.com/angusmcleod/discourse-quick-messages/commit/a444e4df886164e94166eeb29241916087f9aa3d

4 Likes

Yes it is, it’s blinqchat,com

So after updating to the latest version the icon disappeared and was showing up as fa-undefined in the html. The new setting did have envelope filled in by default. To fix it, I had to change it to something else, then change it back to envelope.

strange things happened to me after updating discourse tests-passed git repo. i found a bunch of error messages in my logs (my.site.com/logs) that a certain …ember.js asset couldn’t be found. had to remove the plugin for now since that caused my droplet (2xCPU, 4GB RAM) to spike at 100%+ CPU and become unresponsive.

as i understand it, during rebuild your git repo gets cloned, so i should have the latest version automatically. strange that i seem to be the only one this is happening to…

[edit: i foolishly cleared those error messages from the log before copying them. that’s why i write this here instead of github. don’t have the time to recreae those errors now, but will sooner or later and, if it happens again, submit a bug for this.]

You’re using the flair style and I hand’t added QM-specific css for that yet. It should work once you update:

https://github.com/angusmcleod/discourse-quick-messages/commit/14d0f4b9c9008c7493f644eec83eb69197200782

@cmwebdev Are you still having an issue? See @blinq’s https://blinqchat.com/ of an example of another icon being used.

@phani00 Sorry you had an issue. I need a bit more info to investigate unfortunately. I haven’t had any such issues on my Sandbox.

4 Likes

@angus nope, issue was resolved by changing the option to something else and changing it back to envelope.

I should have been clearer in that post. I was reporting a potential bug. I never wanted to change the icon in the first place. All I did was update the plugin and the icon disappeared.

1 Like

tried to reproduce the error i mentioned, but doesn’t happen again – after rebuild & reboot of the whole box.

may have had something to do with files left in a weird state after simply restarting the app. have seen that in other cases here and on my own install as well. sorry for the noise :roll_eyes:

@angus: the errors are back :frowning_face:

have been using your plugin a lot and i think switching to full-screen mode, either by me or who i have been chatting with, triggered the errors. when i did it my browser crashed as well (vivaldi-snapshot).

those CPU spikes were there too, but not as bad as they used to be. everything went back to normal quickly. probably because i slightly increased my droplet size and rebuilt the app, with more unicorn workers, etc.

attaching one of the backtraces as txt file, looks horrible in here.

here is the corresponding entry in
/var/discourse/shared/standalone/log/var-log/nginx/error.log

2018/06/09 17:49:52 [error] 306#306: *13863 open() "/var/www/discourse/public/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365 d21a5db4f9ee0b85d494e4259cf6cda.js:2:16548" failed (2: No such file or directory), client: 13.57.114.123, server: _, request: "GET /assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:2:16548 HTTP/1.1", host: "discourse.mayapur-community.com"

i don’t see your plugin name mentioned in there, but even though i installed https://meta.discourse.org/t/focus-full-screen-composer-mode/85399 since then, the errors looked the same when they happened last time, w/o the focus-thing.

[edit: no. of error messages keeps increasing even w/o switching from quick to full page chat. but this doesn’t seem to have much of a negative effect on the site’s functioning anymore.]

error-backtrace.txt (1.5 KB)

1 Like

@angus A couple really sweet update ideas could be:

  1. Being able to horizontally scale the pop-up chat like you can vertically.

  2. Being able to make the pop-up chat it’s own window, as done here:

5 Likes

One thing I would really like to see is the ability to only use the toolbar part of the quick messages plugin, I really like the way it makes the private message functionality more obvious with the big button in the top toolbar!

Unfortunately the facebook style message popups are really tricky to make work correctly if you have custom themes or theme components like the header search or material theme and so on, and if you write a typical Discourse post with lots of paragraphs it becomes kinda unreadable in the quick message popup.

2 Likes

Feature Request:
Make the avatar in the chat and the username in the top bar of the chat link to the user’s profile popup/modal like when you click on a username/avatar anywhere else in Discourse.

Thanks!

3 Likes

@angus I really like these requests by @cmwebdev and @Blinq :smile:

Anything happened so far on those requests? Thanks

2 Likes

On the top of Angus’ Quick Messages To Do list, he’s got:

  1. Allow the user to have more than one quick message compose open at once.

Not sure if there is an outright conflict, but certainly seems like allowing each window to scroll horizontally and float anywhere on screen would make implementation of multiple quick message composers open at once more difficult.

That one sounds like it fits right in. Especially handy when you first get a PM from someone new :grinning:

3 Likes

This should be core feature.

1 Like

Yup, @cmwebdev’s request is next up I think, as it’s expected functionality. (@ryanerwin maybe as one of your next mentoring tasks)

I like @ssvenn’s request as well. Perhaps after @cmwebdev’s.

@blinq’s requests are also doable. @ryanerwin The to do list in the readme is out of date, I’ve removed it.

cc @nexo

@phani00 Are you still having issues?

3 Likes

i’m sorry to say that i gave up using the plugin. that same issue, infrequent and unpredictable CPU spikes of several minutes when the plugin was being used by two users at the same time. those spikes made the site unresponsive and it seems i’m the only one that’s happening to.