Quick Messages Plugin

pihentagy · May 21, 2019, 3:02pm

Any clues where should I hunt for errors if seeing this?

thanks

Relevant .yml snip:

hooks:
  after_code:
    - exec:
        cd: $home/plugins
        cmd:
          - git clone https://github.com/discourse/docker_manager.git
          - git clone https://github.com/discourse/discourse-spoiler-alert.git
          - git clone https://github.com/discourse/discourse-solved.git
          - git clone https://github.com/discourse/discourse-voting
          - git clone https://github.com/discourse/discourse-checklist
          # slack integ
          - git clone https://github.com/discourse/discourse-chat-integration.git
          - git clone https://github.com/discourse/discourse-policy
          - git clone https://github.com/discourse/discourse-calendar

          - git clone https://github.com/angusmcleod/discourse-question-answer
          # chat plugin
          # - git clone https://github.com/gdpelican/babble.git
          # quick messages
          - git clone https://github.com/angusmcleod/discourse-quick-messages
          # parallel editing
          - git clone https://github.com/gdpelican/collude
          # reactions
          - git clone https://github.com/gdpelican/retort

angus · May 22, 2019, 4:03am

Hey @pihentagy, do you mean the fact quick messages is not linked to a repo and doesn’t have a settings link? This is just because I hadn’t hooked up this metadata for the plugin.

You can find the quick messages settings by going into your settings and searching for “quick messages”.

In any event, I’ve added that metadata in

https://github.com/angusmcleod/discourse-quick-messages/commit/c4e6cb846c1d825a67a35b5f66b0cd0e8e226860

jord8on · May 22, 2019, 5:46am

Did you figure out a solution for this?

terraboss · May 22, 2019, 7:17am

Unfortunately not.

angus · May 22, 2019, 7:27am

@jord8on Hey, are you talking about this?

Happy to add it into the work schedule if we can:

Get a feature request: Feature Request
Get 5 votes or a sponsor for it.

See further here: https://discourse.angusmcleod.com.au/k/how-to/how-to-request-a-plugin-feature/894

cc @terraboss

Bank_Live · June 2, 2019, 8:51am

Plugin outside

hewo7 · August 14, 2019, 6:02am

Yes on mobile devices the chat windows renders outside the screen. On my forum it is the same.
Is there a solution for this?

angus · August 14, 2019, 11:56pm

@hewo7 @Bank_Live Thanks for the prompts about this. I’ll fix it tomorrow

calebs · August 15, 2019, 12:36am

@angus A great plugin, works perfectly!

I guess this isn’t a priority at the moment, but while you are fixing things, would it be possible to fix these:

New Message text is a bit off.

Quick1

Emojis and Image icons are not alligned properly.

Quick2

Maybe move this field, as well as the icons, as they are too close to the edge on the top.

Quick3

Thank you and once again, well done!

angus · August 16, 2019, 7:52am

@Bank_Live @hewo7 The mobile UI bug is fixed:

https://github.com/paviliondev/discourse-quick-messages/commit/b5f33d389539e143ebe898fe97c029669acf8e56

@calebs I’ve also made some style tweaks and some other fixes

https://github.com/paviliondev/discourse-quick-messages/commit/09b007cee78a2fd2707bd3d75373d8ffb06b59e1

hewo7 · August 16, 2019, 8:23am

@angus Thank You! Works perfect!

AndyatFocallocal · August 17, 2019, 8:53pm

I seem to be getting a bug where users can carry on typing below the visible screen. I’ve turned off all plugins which i’m able to turn off and the issue remains. Is anyone else having this?

angus · August 18, 2019, 11:13pm

Thanks @AndyatFocallocal I’ve pushed a fix for this.

https://github.com/paviliondev/discourse-quick-messages/commit/ed8888dd7feac06fa23430ca31bc1d5b7a565904

Raj_Rathore · September 19, 2019, 8:02am

Thanks for creating and maintaining this awesome plugin, I have encountered a few issues with this:-

The images are being shown fine inside the message box but the lightbox doesn’t work. Clicking the image takes to image link and doesn’t show it in the lightbox, thus breaks the conversation. Is there a way to disable lightbox in a quick message window or have lightbox working properly.
It doesn’t mention the subject of the message anywhere, and thus the message list becomes very hard to recognize.
It doesn’t display the message in the mobile view.

20%20PM

And shows following in the console

_application-91a6f00c2b614e1bd00e24153375bde25ec3d14f53dcdcfc6a19c8d7ea0e5d89.js:14093 Uncaught TypeError: e.substr is not a function
    at n.excerptTruncated (_application-91a6f00c2b614e1bd00e24153375bde25ec3d14f53dcdcfc6a19c8d7ea0e5d89.js:14093)
    at n.<anonymous> (_application-91a6f00c2b614e1bd00e24153375bde25ec3d14f53dcdcfc6a19c8d7ea0e5d89.js:83)
    at n.i.get (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:27422)
    at J (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:25836)
    at t.r.compute (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:13693)
    at t.value (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:13431)
    at t.value (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:57889)
    at e.t.initialize (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:57350)
    at e.t.peek (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:57325)
    at Object.evaluate (_ember_jquery-d430881a3fb1403871256e5a02423c4b20a78793685e92088613ca9a701baf88.js:58536)

Mittineague · February 10, 2020, 12:31am

Is this a plugin or a theme? The former is added by editing the yml file, the latter the UI

Olivier_Lambert · February 18, 2020, 4:53pm

The feature isn’t live on the sandbox? (https://thepavilion.io/) I’d love to see the plugin in action.

DaleKramer · February 19, 2020, 12:31pm

Is there a way to allow only certain ‘groups’ to use your Quick Messages Plugin

If not, would you consider adding this feature

By the way, we use Quick Messages a LOT and love it but would like to limit its’ use, perhaps trust level would be another acceptable way to do that…

EDIT: Ooops, we just figured out how to acceptably manage this using your ‘quick message required badge’ settings parameter…

Hifihedgehog · February 20, 2020, 9:58pm

Are mobile devices supposed to be able to work with this plugin? When I attempt to use the Quick Message interface on my iPhone Xr in Safari in iOS 13, I experience various UI bugs. I cannot tap into the text box to enter a username for the recipient because it doesn’t register the tap. Also, when I start type and then tap outside to hide the on-display keyboard, the message box extends up into the header of the forum page so I cannot close the message box. Very strange. I wanted to use this in lieu of Babble, but it has so many UI issues that it’s not currently an option.

Justin_Vega · February 21, 2020, 2:15pm

What version of iOS 13 are you on? Have you tried updating to the latest version?

Hifihedgehog · February 23, 2020, 2:58pm

I am on the latest release. I have access to several different iPhones and I think the issue comes down to the curved screen with the sensor cutout or “notch” at the top. The Xr and 11 Pro (standard and Max) have this issue, whereas the iPhone 6S does not. It may be that Safari is to blame for improperly rendering the display boundaries in interpreting the code.