Quick question about Email Deliverability Test

RichardC · March 31, 2021, 6:57pm

The first item in the Email Deliverability email is:

Be sure to set the notification email from: address correctly in your site settings. The domain specified in the “from” address of the emails you send is the domain your email will be validated against .

Does this refer to the server-level settings configured during install? Or something in the admin settings?

pfaffman · March 31, 2021, 7:40pm

That’s no longer true.

If you ran discourse-setup recently it asked you what address you wanted (suggesting the same default in the message), the notification_email is set by DISCOURSE_NOTIFICATION_EMAIL in your app.yml. And since it’s set that way, the setting no longer shows up in the UX.

To change it you’ll need to run discourse-setup or edit app.yml and rebuild (though ./launcher destroy app; ./launcher start app may work a bit faster if you haven’t done an upgrade from the command line).

This isn’t quite a bug, but it’s close.

@sam (or @codinghorror since we worked on this)-- someone needs to edit test_mailer.text_body_template accordingly. I think that it’s safe to just ignore the case where the setting isn’t in app.yml and tell people to run discourse-setup, as it seems unlikely that someone will go looking for this setting if it’s not wrong.

codinghorror · March 31, 2021, 10:38pm

OK, what’s your recommendation for the edit? Can you propose an edit here, in a reply?

pfaffman · April 1, 2021, 3:45pm

github.com

discourse/discourse/blob/main/config/locales/server.en.yml#L2705


      
          reply_by_email_address_is_empty: "You must set a 'reply by email address' before enabling reply by email."
          email_polling_disabled: "You must enable either manual, POP3 polling or have a custom mail poller enabled before enabling reply by email."
          user_locale_not_enabled: "You must first enable 'allow user locale' before enabling this setting."
          at_least_one_group_required: "You must specify at least one group for this setting."
          invalid_regex: "Regex is invalid or not allowed."
          invalid_regex_with_message: "The regex '%{regex}' has an error: %{message}"
          email_editable_enabled: "You must disable 'email editable' before enabling this setting."
          staged_users_disabled: "You must first enable 'staged users' before enabling this setting."
          reply_by_email_disabled: "You must first enable 'reply by email' before enabling this setting."
          discourse_connect_url_is_empty: "You must set a 'discourse connect url' before enabling this setting."
          enable_local_logins_disabled: "You must first enable 'enable local logins' before enabling this setting."
          min_username_length_exists: "You cannot set the minimum username length above the shortest username (%{username})."
          min_username_length_range: "You cannot set the minimum above the maximum."
          max_username_length_exists: "You cannot set the maximum username length below the longest username (%{username})."
          max_username_length_range: "You cannot set the maximum below the minimum."
          invalid_hex_value: "Color values have to be 6-digit hexadecimal codes."
          empty_selectable_avatars: "You must first upload at least two selectable avatars before enabling this setting."
          category_search_priority:
            low_weight_invalid: "You cannot set the weight to be greater or equal to 1."
            high_weight_invalid: "You cannot set the weight to be smaller or equal to 1."
          allowed_unicode_usernames:

Maybe:

Be sure to set the notification email from: address correctly by running discourse-setup or changing DISCOURSE_NOTIFICATION_EMAIL in your app.yml. The domain specified in the “from” address of the emails you send is the domain your email will be validated against.

That might get it. What do you think?

RichardC · April 1, 2021, 4:03pm

I’m very new to Discourse, but it would make more sense to me (assuming it’s accurate) to replace the second sentence with:

Use a from: email address domain that can be validated (e.g. if your from: email address is forum@example.com be sure your email provider can validate emails from example.com)

codinghorror · April 4, 2021, 6:01pm

So the proposal is to change

Be sure to set the notification email from: address correctly in your site settings. The domain specified in the “from” address of the emails you send is the domain your email will be validated against.

to

Be sure to set the notification email from: address correctly by running discourse-setup or changing DISCOURSE_NOTIFICATION_EMAIL in your app.yml. Use a from: email address domain that can be validated (e.g. if your from: email address is anything@example.com be sure your email provider can validate emails from example.com.)

I guess that’s fine; how do you feel about it @Stephen @pfaffman ?

pfaffman · April 5, 2021, 3:14pm

That seems like an improvement.

While we’re at it…

Maybe:

Also, @falco was instrumental in the decision to move the notification_email to discourse-setup. He may have opinions.

codinghorror · April 5, 2021, 5:31pm

Cool! @falco you want to chime in, and then I can make the edits?

Falco · April 5, 2021, 6:18pm

Your copy looks fine to me

Topic		Replies	Views
Email delivery configuration checklist Self-Hosting configuring , reference	4	6346	November 23, 2021
Can domain name of discourse hosting and sending emails be different? Installation email	10	2616	May 20, 2023
Suggestion - allow optional system email "from" setting during setup Feature	8	1450	August 12, 2019
What sets the domain in the Email Settings? Installation unsupported-install	14	1104	February 24, 2019
How do I change the email "FROM" address? Support	8	691	September 5, 2020

Quick question about Email Deliverability Test

Related Topics