Qunit tests not deterministic in Plugin?

merefield · July 20, 2022, 8:48am

I seem to be running into a race condition in Qunit, in my case running:

rake "plugin:qunit[discourse-multilingual]" with a branch installed.

I’m declaring a function in my initializer (i’m extending I18n)

The tests sometimes (25%?) seem to run before the plugin’s ember initializer has run and fails because the function is not defined.

How do I ensure the plugin’s initializer js has run before the test fires?

test:

github.com

paviliondev/discourse-multilingual/blob/c7c0226ce3b3ef9cd2d575efa4c446834699271e/test/javascripts/acceptance/translate-tag-test.js.es6#L12


      
          import { test } from "qunit";
          import { tag_translations } from "../fixtures/tag-translations";
          import I18n from "I18n";
          
          
acceptance("Translated tags", function () {
            I18n.tag_translations = tag_translations;
          
          
  test("translates included data correctly", async (assert) => {
              I18n.locale = "fr";
              assert.equal(I18n.default.currentLocale(), "fr");
              assert.equal(I18n.translate_tag("motor-car"), "voiture");
            });
          
          
  test("translates included data correctly", async (assert) => {
              I18n.locale = "en";
              assert.equal(I18n.default.currentLocale(), "en");
              assert.equal(I18n.translate_tag("motor-car"), "motor-car");
            });
          });

definition:

github.com

paviliondev/discourse-multilingual/blob/c7c0226ce3b3ef9cd2d575efa4c446834699271e/assets/javascripts/discourse/initializers/multilingual-initializer.js.es6#L39


      
            Composer.serializeOnCreate(
              "content_language_tags",
              "content_language_tags"
            );
            Composer.serializeToTopic(
              "content_language_tags",
              "topic.content_language_tags"
            );
          }
          
          
I18n.translate_tag = function (tag) {
            if (
              typeof I18n.tag_translations !== "undefined" &&
              I18n.tag_translations !== null &&
              typeof I18n.tag_translations[I18n.default.currentLocale()] !==
                "undefined" &&
              typeof I18n.tag_translations[I18n.default.currentLocale()][tag] !==
                "undefined"
            ) {
              return I18n.tag_translations[I18n.default.currentLocale()][tag];
            } else {

intermittent error:

TypeError: _I18n.default.translate_tag is not a function

merefield · July 20, 2022, 11:03am

OK I resolved this by refactoring. I moved my function out of I18n and into an existing multilingual module.

Something about extending I18n here is not reliable in all scenarios, least of all unit testing, apparently!

Topic		Replies	Views
Strange QUnit behaviour?: test failing because setting value doesn't survive Dev	4	287	September 6, 2023
Plugin QUnit tests are not running as part of rake qunit:test Dev	7	1937	July 17, 2017
Developing Discourse Plugins - Part 6 - Add acceptance tests Developer Guides testing , plugin-guides , tutorial	32	16473	June 2, 2022
How to test themes or theme components? Dev	16	2059	January 15, 2022
ERROR: Unexpected token: punc «)» from qunit helper during a rebuild Support	4	1707	May 23, 2021

Qunit tests not deterministic in Plugin?

Related topics