Quote Reply popup does not appear in PMs

[RaceProUK]

The pop-up still appears in public topics, just not in PMs; is this intentional?

Issue found on TDWTF; it’s not present on @riking’s test forum, which is running an older version of Discourse.

[thorbjorn42gbf]

I was seconds away from reporting this. Seconds.

[cpradio]

Feels like a bug, as the function exists in 1.2.0-beta4. My guess is the latest change around closed topics accidentally broke it in PMs? @eviltrout

Quote post from closed topic

Someone just opened a followup on a closed topic. I wanted to quote one of the post in that closed topic to support why I think the person should not have opened another topic. But… turns out you can select text in a closed topic, but the quote button won’t appear. The editor is also hidden. Of course this makes sense within that closed topic. But it’s not a very uncommon thing to quote from a closed topic into another topic.

[codinghorror (Jeff Atwood)]

I think this is a legit new bug for you @eviltrout

[eviltrout (Robin Ward)]

Thanks for letting me know. It was a case I messed up here, but fixed here:

https://github.com/discourse/discourse/commit/7a38360fbd97a622d153c7a538657d9a5116af81