Кавычки в полном имени ломают разметку цитат

zogstrip · 12.Декабрь.2025 17:49:42

I’m afraid there isn’t

The simplest and safest is to strip them, not ideal, but better than broken I guess?

github.com/discourse/discourse

FIX: strip quotation marks from names in quote BBCode

main ← strip-quotation-marks-from-names-in-quote-bbcode

merged 08:46AM - 18 Dec 25 UTC

ZogStriP

+30 -1

When "display name on posts" is enabled and "prioritize username in UX" is disab…led, quoting a user with quotation marks in their display name (e.g., `John "The Dev" Smith`) breaks the quote markdown: [quote="John "The Dev" Smith, post:1, topic:2"] The BBCode parser's regex `"([^"]+)"` stops at the first `"` inside the name, capturing only `John ` instead of the full name. Alternatives considered: - Backslash escaping (`\"`): Would require updating the parser regex to support escape sequences and adding unescape logic. Adds complexity and risks breaking existing quotes. - URL encoding (`%22`): Requires decoding when rendering. Using `decodeURIComponent` on user input creates XSS risk. A safe decoder that only decodes specific characters adds complexity and attack surface for minimal benefit. The simplest solution is to strip quotation marks from names when building the quote BBCode. This is safe (no user input decoding), simple (no parser changes), and the minor cosmetic loss in the quote attribution is an acceptable trade-off. The `stripQuotationMarks` function is defined alongside the existing `QUOTATION_MARKS` array in bbcode-block.js to keep related logic together and avoid duplication. Ref - https://meta.discourse.org/t/391153

Тема		Ответов	Просм.
Quoting broken when name matches username Bug	21	1851	27.04.2022
Display full name not username when attributing quote in RTE Bug composer	16	88	27.02.2026
[quote] loses backslashes on this super edge case Bug markdown-it-review	4	1116	26.06.2017
Can a Theme have a quote display real name instead of username? Feature	2	685	22.05.2020
"display name on posts" should apply to quotes, too Feature	2	447	25.02.2026

Кавычки в полном имени ломают разметку цитат

Связанные темы