Quotes pointing to deleted post gets stuck loading

Go to the following post:

Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.

2 Me gusta

This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.

1 me gusta

Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.

As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.

Can’t know that until we check on click.

Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.

4 Me gusta

This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh

I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.

Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.

4 Me gusta

Sure can you make that change @eviltrout? This one is long overdue.

3 Me gusta

I think this was done? If I try as anonymous I get a trash icon instead.

3 Me gusta

Good ol’ @neil did it!

3 Me gusta

Parece que tenemos un tipo de regresión aquí. Echa un vistazo al enlace incrustado Manually update Discourse and Docker image to latest - #112 de Dean, donde se muestra un «cargando» infinito. Aún funciona en una cita simple que contiene un enlace, pero no para un tema/publicación enlazada eliminada.


EDITO: Al observar la publicación original de este tema, parece que no funcionará con un enlace dentro de una cita. Muestra «cargando» durante menos de un segundo, pero no muestra el icono de «papelera» que indica que el enlace/texto de referencia ha sido eliminado. En este caso, un usuario normal tiende a hacer clic en el enlace de la cita y termina en la página 404.

Así que funciona con citas de texto muy simples, sin enlaces en su interior.

2 Me gusta

Is this fixable easily @eviltrout? Maybe take a peek Monday.

1 me gusta

Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.

https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4

3 Me gusta