Quotes pointing to deleted post gets stuck loading

Go to the following post:

Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.

2 个赞

This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.

1 个赞

Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.

As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.

Can’t know that until we check on click.

Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.

4 个赞

This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh

I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.

Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.

4 个赞

Sure can you make that change @eviltrout? This one is long overdue.

3 个赞

I think this was done? If I try as anonymous I get a trash icon instead.

3 个赞

Good ol’ @neil did it!

3 个赞

看来这里出现了一种回归问题。请查看 Dean 提供的嵌入链接 Manually update Discourse and Docker image to latest - #112 在包含链接的简单引用中它仍然有效[/s],但对于已删除的已链接主题/帖子则无效。


编辑:查看该主题的原始帖子,似乎当引用中包含链接时它无法正常工作。它显示“加载中”不到 1 秒,但不会显示表示引用链接/文本已被删除的“垃圾桶”图标。在这种情况下,普通用户倾向于点击引用中的链接,最终跳转到 404 页面。

因此,它仅适用于非常简单的文本引用,且引用内部不包含链接。

2 个赞

Is this fixable easily @eviltrout? Maybe take a peek Monday.

1 个赞

Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.

https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4

3 个赞