Well, an install failed (my install script gets an API key so that it can set the mailgun_api_key). I checked too on my local dev instance. $ rake api_key:get rake aborted! NoMethodError: undefined method `create_master_key' for ApiKey (call 'ApiKey.connection' to establish a connection):Class Did …

Thanks @pfaffman , I’ve made a comment on the PR [изображение] pfaffman: my install script Just checking - this is your personal script, not the standard install script?

Yes! This didn’t break a normal install, just the piece of my post-install stuff that needs an API key to set the mailgun_api_key. I suspect that few people use this rake task.

:+1: out of interest, do you clear up the api key when you’re done? You may have noticed I’ve made a lot of changes recently so that we keep better track of API keys. We’re trying to reduce “unused” api keys being left as potential security holes. If this is running on the server, maybe you could u…

Oh! I think it would be better to not change the key if it already exists or to have a create_if_not_exists task. It’s very handy to be able to get the existing key with a rake task without having to change it and break anything that uses the key. A few places in my Ansible tooling, if I don’t have…

[изображение] pfaffman: It’s very handy to be able to get the existing key with a rake task without having to change it and break anything One change I made is that you can now have multiple keys per user (or multiple ‘master keys’). That means that every integration can be given it’s own key…

Sure! I think that would be just great.

How’s this ? rake api_key:get_or_create_master["Onboarding Key"] If there are no objections I’ll merge it in a few hours

Looks good to me! And my playbook was still up in my editor, so I’m already committed. :slight_smile:

Merged in https://github.com/discourse/discourse/commit/63bd07492ea07a999d8359409a0ea4000bce364f

Sorry @pfaffman , but I’m afraid I will have to remove this new rake task in an upcoming PR. We are going to be hashing API keys in the database, so it will be fundamentally impossible to retrieve an existing key. https://github.com/discourse/discourse/pull/8438 I’ve replaced the get_or_create_mast…

Rake api_key:get сломан

Поддержка

david (David Taylor) 08.Ноябрь.2019 19:03:25 8

Как насчёт этого?

rake api_key:get_or_create_master["Onboarding Key"]

Если возражений нет, я объединю его через несколько часов.

Тема		Ответов	Просм.
Setting the api key via console Development	11	1599	08.07.2020
Adding command line tools support for user api keys Development	23	4045	04.01.2019
404 Error returned when using DiscourseAPI Gem to Generate User API Key Development rest-api	2	1001	07.02.2020
User API keys specification Integrations rest-api , reference	69	37869	22.09.2025
Rake task for merging users Announcements new-feature , merge-user	61	14745	12.08.2022

Rake api_key:get сломан

Связанные темы