I just spent 10 minutes clicking the
884 times on the /invited/pending page.
AI-generated summary
A discussion titled “Re-send all pending invitations” began with rhyolight expressing frustration with manually resending pending invitations. codinghorror suggested adding a “resend all pending invites” button, which techAPJ implemented. The feature is now available, visible when there are 5 or more pending invites.
rhyolight and techAPJ also addressed rate limits for this feature. Initially, it was limited to 1 resend per day for non-staff, and 10 per hour. However, codinghorror pointed out that the feature should only be available to staff. techAPJ then made the feature staff-only. The discussion also touched on applying rate limits to staff users, with techAPJ considering amending the RateLimiter library to achieve this.
Sure, @techapj can you add to your list a “resend all pending invites” button for this page? Makes sense.
This feature is now available. ![]()
“Resend all Invites” button will be visible when there are 5 or more pending invites.
https://github.com/discourse/discourse/commit/c4e1ad0953bc8cbd4f2b8950b96e87393746f531
Does this have appropriate ratelimits (that apply to admins)?
It has now ![]()
- Resend all Invites limited to 1 per day.
- Resend Invite limited to 10 per hour.
(not applicable on staff)
https://github.com/discourse/discourse/commit/a9c6df198cbbc0b8f5bf5b7de42e71c2cdf3d150
Would non staff even ever see this button to resend all invites? I don’t know why it should even be offered to non staff. @riking was proposing rate limits even for admins here so I feel there has been a giant miscommunication…
Okay, I made this feature staff only.
Regarding rate limits even for admins, our current RateLimiter library makes the rate unlimited for staff users.
Should I amend the library to allow rate limits to be applied on staff users too?
