Lhc_fl
(Linca)
April 26, 2023, 2:54pm
1
A recent discourse update seems to have broken the chat minimum character limit setting. Even if I set the minimum characters to 1, I have to enter two characters to send the chat message.
This is quite unfriendly for many situations. Especially in Chinese, there are a large number of expressions that only need one char. This bug makes such expressions unable to be sent out normally.
6 Likes
j.jaffeux
(Joffrey Jaffeux)
April 26, 2023, 3:02pm
2
Will have a look, I suspect it was just not working before, and the way we check length is not working with these characters.
2 Likes
j.jaffeux
(Joffrey Jaffeux)
April 26, 2023, 3:04pm
3
Can you paste me the exact char you are using please?
1 Like
Canapin
(Coin-coin le Canapin)
April 26, 2023, 3:05pm
4
Here it is, here it is: 好
2 Likes
j.jaffeux
(Joffrey Jaffeux)
April 26, 2023, 3:05pm
5
Ooops… no it was just a stupid mistake. Will have the fix shortly.
2 Likes
j.jaffeux
(Joffrey Jaffeux)
April 26, 2023, 3:35pm
6
I just merged this which will fix it:
discourse:main
← jjaffeux:chat/mini-length
opened 03:21PM - 26 Apr 23 UTC
Before this fix we were only considering `>` and not `>=`, this also adds two te… sts.
This should be available in tests-passed soon, thanks for the report
6 Likes
Lhc_fl
(Linca)
April 26, 2023, 3:39pm
7
Thank you so much for the super quick fix!
(the bug is exactly the same as I guessed lol)
3 Likes
j.jaffeux
(Joffrey Jaffeux)
Closed
April 27, 2023, 3:40pm
8
This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.