Remove `spork-rails` from Discourse


(Alan Tan) #1

As part of our efforts to upgrade to Rails 5, we’ll need to deprecate spork-rails which currently locks Rails to < 5. However, Rails 5 support for the gem is probably never going to land as the last commit made to the gem is way back in 2013. The main thing using spork in our code base is autospec so we’ll need to figure out an alternative for it.

Going to tag this #pr-welcome in the meantime.


(Sam Saffron) #2

Not strictly the case, it is optional, have not used spork personally for years, can be nuked with impunity


#3

Since there’s action cables integrated in Rails 5 to add support for WebSockets, can you confirm Discourse won’t use it :slight_smile:


(Sam Saffron) #4

We will not add the action cable dependency and have zero plans of using it


(Bianca) #5

Hello,

This PR should remove all traces of Spork.


(Alan Tan) #6

Thank you @nbianca, PR has been merged with tests all :white_check_mark:


(Alan Tan) #7