When usernames are derived from emails (especially work emails), they often are very similar to the users real name. If the user has set their real name (and if real names are not hidden via site settings) this currently results in invite emails starting like this
John Doe (doe) invited you to join
As far as I can tell without any knowledge of ruby, this is where the John Doe (doe) part gets rendered:
I donāt see the benefit of mentioning the username at all if the real name is available. After all, you are inviting someone who is not yet a member (most of the time at least) and hence canāt relate to the username anyway. So I would like to change line 18 to
invitee_name = "#{invite.invited_by.name}"
but I donāt know how to achieve this on my site and Iām also hesitant to fiddle with the core code. Is this a change that would make sense for the core? If not, could someone give me some hints how to make that change locally while maintaining upgradability?
BTW: why is the variable called invitee_name when āinviteeā commonly designates the invited person, not the inviting person?
So, just to understand things better, does what Iām trying to do imply forking Discourse? I hope there is a simpler way for making such a minor changeā¦
Itās particularly confusing when editing the email templates for Invites - I thought %{invitee_name} would put in the name of the person I was inviting so I changed the sentences to reflect this, only for the invites to make no sense at all because %{invitee_name} actually inserted the username of the person who created the invite.
I would support the OP in this topic who suggested the use of full name if it is available, as opposed to username, which can occasionally be a username that is opaque to the new user.
But we do need to change %{invitee_name} to %{inviter_name} because itās maddeningly confusing, and inaccurate. I might actually be able to do this, so if youād be interested in a PR I will have a go.
If the invite said codinghorror only and I knew Jeff personally I might not have any idea who codinghorror was and be reluctant to accept the invite.
If the invite said Jeff only and I knew Jeff personally I would be more likely to accept the invite, but I might not know that his member name was codinghorror.
