Replacing remote images with local uploaded images issue

evantill · June 3, 2015, 9:31pm

reprocase:

insert an image (using an external url) in a post using a link reference.
wait for the system to replace the external url with an uploaded copy.
the url is replaced by an html <img> tag.

bug: the url in the refence il also replaced with the html <img> tag.

Mittineague · June 3, 2015, 9:39pm

I’m not following.

Are you saying you want the link to an image in the post to not be changed into the image?

That is the expected behavior.

If you want the link to stay a link don’t put it on it’s own line
Or enclose it in backticks so it gets rendered as a text URL

evantill · June 3, 2015, 9:46pm

No @Mittineague, this is not the point.

Maybe this gist will help:

Mittineague · June 3, 2015, 9:50pm

Ahh, you’re not using the correct MarkDown syntax for links.

http://daringfireball.net/projects/markdown/syntax#link

It should be
[link text here] (URL here)

* with the URL in parentheses not as HTML or a “raw” URL

EDIT
:d’oh:
Sorry, I misunderstood what you’re wanting to do. Not a link, but

http://daringfireball.net/projects/markdown/syntax#img

Reference-style image syntax looks like this:

![Alt text][id]

Where “id” is the name of a defined image reference. Image references are defined using syntax identical to link references:

[id]: url/to/image “Optional title attribute”

evantill · June 3, 2015, 9:56pm

Let try my example on meta:

Ou est Charlie ?

Char

Mittineague · June 3, 2015, 9:59pm

Let me try

![Char](https://img.over-blog.com/4/22/39/26/Personnages-ridicules/Charlie/Where-is-waldo-ou-est-charlie.jpg)

Char

Same thing happens

<img src="https://img.over-blog.com/4/22/39/26/Personnages-ridicules/Charlie/Where-is-waldo-ou-est-charlie.jpg" alt="Char" height="308" width="292">

evantill · June 3, 2015, 10:03pm

Did you confirm this is a bug ?

Mittineague · June 3, 2015, 10:04pm

I don’t know. What is the expected behavior?

evantill · June 3, 2015, 10:12pm

expected result shoud be :

exemple here :

Ou est Charlie ?

![Char][Charlie]

[Charlie]: /uploads/default/original/1X/70bdb0afec7b129ae882d21587d82d09c2f0a6c3.png

and not :

exemple here :

Ou est Charlie ?

![Char][Charlie]

[Charlie]: <img src='/uploads/default/original/1X/70bdb0afec7b129ae882d21587d82d09c2f0a6c3.png'>

Mittineague · June 3, 2015, 10:18pm

Where are you seeing that? I can’t find it.

evantill · June 3, 2015, 10:30pm

you need to wait some job maybe this one:

github.com

discourse/discourse/blob/17d07a8b9a3db9d963f9d7d5bd73504984ef3188/app/jobs/regular/pull_hotlinked_images.rb

require_dependency 'url_helper'
require_dependency 'file_helper'

module Jobs

  class PullHotlinkedImages < Jobs::Base
    include UrlHelper

    def initialize
      # maximum size of the file in bytes
      @max_size = SiteSetting.max_image_size_kb.kilobytes
    end

    def execute(args)
      return unless SiteSetting.download_remote_images_to_local?

      post_id = args[:post_id]
      raise Discourse::InvalidParameters.new(:post_id) unless post_id.present?

      post = Post.find_by(id: post_id)

This file has been truncated. show original

evantill · June 3, 2015, 10:43pm

the problem seems to be in this regexp because my link reference is not a number :

github.com

discourse/discourse/blob/17d07a8b9a3db9d963f9d7d5bd73504984ef3188/app/jobs/regular/pull_hotlinked_images.rb#L66


      # there are 6 ways to insert an image in a post
      # HTML tag - <img src="http://...">
      raw.gsub!(/src=["']#{escaped_src}["']/i, "src='#{url}'")
      # BBCode tag - [img]http://...[/img]
      raw.gsub!(/\[img\]#{escaped_src}\[\/img\]/i, "[img]#{url}[/img]")
      # Markdown linked image - [![alt](http://...)](http://...)
      raw.gsub!(/\[!\[([^\]]*)\]\(#{escaped_src}\)\]/) { "[<img src='#{url}' alt='#{$1}'>]" }
      # Markdown inline - ![alt](http://...)
      raw.gsub!(/!\[([^\]]*)\]\(#{escaped_src}\)/) { "![#{$1}](#{url})" }
      # Markdown reference - [x]: http://
      raw.gsub!(/\[(\d+)\]: #{escaped_src}/) { "[#{$1}]: #{url}" }
      # Direct link
      raw.gsub!(src, "<img src='#{url}'>")
    end
  rescue => e
    Rails.logger.error("Failed to pull hotlinked image: #{src}\n" + e.message + "\n" + e.backtrace.join("\n"))
  ensure
    # close & delete the temp file
    hotlinked && hotlinked.close!
  end
end

codinghorror · June 3, 2015, 11:47pm

I see we should probably fix that @zogstrip.

sam · July 21, 2022, 5:38am

Took a while, but I believe @david’s rework of this sub system fixed this long standing issue.

Topic		Replies	Views
System user replaces wrong URL when it downloads local copy of image Bug	16	2584	December 3, 2018
Code block image link gets modified when hotlinked image is downloaded Bug	2	576	September 27, 2023
Upload button remote external image URL field not showing Feature	6	1000	December 14, 2021
Images posted via HTTP URL are not being displayed until downloaded to local Bug	17	2021	January 24, 2019
Issue with image uploads on embedded topics Bug	4	1044	April 5, 2021

Replacing remote images with local uploaded images issue

Related topics