Downloading remote images doesn't work with protocol-less srcs

Bug
1

Long
Long600×542 48.3 KB

The image above, embedded with ![Long](//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/9/a/9a3bc7ce270b38e31e0c1425043b3e51539e3b3a.jpg) will be downloaded locally, and the image src will be replaced with the new url.

The image below, embedded with ![cat](//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/7/6/7685d7c6a3ecc9df487f7e4c32d3cb4ba571b032.jpg) won’t, because of the bug.

What happens is the image is correctly downloaded locally, but then the url replacement won’t work, because the code is looking for a src with http: prepended to it.

(I’m going to look like a right numpty if this demonstration doesn’t work, but anyway, there’s a fix here: https://github.com/discourse/discourse/pull/4643)

cat
cat600×543 58.3 KB

2 Likes
2

Seems to work fine?

![cat](//i.imgur.com/7Z8brhn.jpg)

cat
7Z8brhn.jpg600×543

1 Like
3

@LeoMcA imgur won’t work to prove that here on meta, try with another hosting service.

2 Likes
4

Aaaah, cheers! The first post now shows the bug, after moving to embedding from the Mozilla Wiki (it was the last place I thought you were going to have blacklisted… and I was right!)

Just to clarify, this is about the behaviour triggered by enabling the download remote images to local site setting.

The issue isn’t whether the image is displayed or not, but where it’s hosted. Both images were embedded from the Mozilla Wiki, but only the first has been downloaded locally to your cdn. (The second has been downloaded, but the regexp used to edit the post failed because it was looking for a url with http: at the start)

This has also exposed another bug, the url in the code block also got replaced. It initially read:

Do we also want to fix this?

4 Likes
5

Sure if you’re up to it :wink: Beware, there lies :dragon:

3 Likes
6

Is this still an issue after the massive commonmark refactor @LeoMcA?

7

Let’s see:

Nightly

![Nightly|50x50](//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/4/f/4f2567048904a08ba6390cd498a77ec6b9753d0b.png)

Nightly

![Nightly|50x50](//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/4/f/4f2567048904a08ba6390cd498a77ec6b9753d0b.png)

<img src='//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/4/f/4f2567048904a08ba6390cd498a77ec6b9753d0b.png' width="50" height="50">

<img src='//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/4/f/4f2567048904a08ba6390cd498a77ec6b9753d0b.png' width="50" height="50">

8

I don’t think it’s fixed since it’s not a markdown issue but a PostCookedProcessor issue.

1 Like
9

I can’t even get it to trigger remote image downloading - let alone replacing the url in the code block - so I’m not sure what I’m doing wrong.