Retort - a reaction-style plugin for Discourse

#288

Is this related to the lodash update @gdpelican?

1 Like
#289

I think it was stated lodash related in a bug post?

I’m gonna try reenabling and rebuilding as it appears fixed now?

I’ll let you know if I got success!

#290

I’ve just pushed a fix which removes _.contains from the repo, so this should start working again.

8 Likes
Aborting! CDN must have a protocol specified
#291

Awesome, thanks for getting to this so quickly.

Lodash was fixed, it’s still worth letting developers know when a dependency change interferes with their plugin.

#292

Hey, gdpelican. Do you think its possible that Instead of opening a pop up…

have a option for similar Facebook-style box when you try to react?

38

#293

It’s already possible to reduce the style of the picker using the retort limited emoji set setting, and reducing the window size via CSS:

.retort-picker.emoji-picker {
height: 30px;
}

It’s going to default to relaxed|laughing|+1|heart|rage|poop, but that can be changed too.

The Facebook UI element is still a popup, the only difference there would be the shade, which could also be overridden in CSS:

.retort__emoji-picker-wrapper--active {
    background: rgba(0,0,0,0.5);
}

Although in that case you may also want to make the picker border darker, to be more visible and potentially play around with the location.

3 Likes
#294

Yeah, but I was thinking that, instead of opening a box, you could choose like Facebook (hover opening the options).

Its javascript, I think.

#295

Setting up a certain trust level or group membership as requirement would be great. I would love to implement it as premium feature for premium members in my forum.

1 Like
#296

I really want to include this in our forum that’s being imported from phpbb… I’m just not sure on how the users will understood that they will have a “reactions” and a “like” altogether… I fear that they will end ignoring the like in favor of the reactions :confused:

#297

I suppose, you could tweak the UI with CSS and/or Jquery so that people see multiple emojis to react with

What would be even more amazing is to grey out the extra emojis and lead the CTA to buy a certain group membership to enable that feature.

#298

Retort includes the retort limited emoji set setting to present a fixed list of emoji.

You could pair that down to 3/4 reactions beyond ‘like’ to encourage users to use the like button when it’s relevant.

That doesn’t sound amazing, that sounds really really user-hostile.

#299

Seems like disabling the plugin and rebuilding still breaks the post content. I had to go to finder -> ~/discourse/plugins, then had to manually remove the retort folder.

#300

@gdpelican The retort plugin is inteferring with the emoji selection box, see this post:

https://meta.discourse.org/t/emoji-button-not-showing-emojis-when-browser-full-screen/119468/10

#301

I can confirm the above bug

#302

Hi @Vaping_Community, @Jose_C_Gomez :slight_smile:

Does this PR fix your problem? FIX: Prevent emoji-picker from not showing by SantosGuillamot · Pull Request #7856 · discourse/discourse · GitHub

We were having similar troubles and now are fixed with this. (Maybe you have to rebuild your app)

#303

Yes it is now fixed.

#305

I offer my users an iOS/Android app that they can use to access my forum.

When opening topics in the apps, often the posts won’t load properly, or only the navigation will appear.

I’m also seeing these errors in /logs:

TypeError: Cannot read property 'get' of undefined
    at i.disabledFor (https://.../assets/plugins/retort-0e38325ecc1e77022640749d263c616fa2014661562526df5557240511da536a.js:1:3734)
    at https://.../assets/plugins/retort-0e38325ecc1e77022640749d263c616fa2014661562526df5557240511da536a.js:1:4642
    at https://.../assets/application-005c06796edb69789ba3362843ad68e4f0e5b629e4bce0ccfce36db53770401e.js:75:13612
    at Array.map (<anonymous>)

and

TypeError: undefined is not an object (evaluating 'e.get')
disabledFor@https://.../assets/plugins/retort- 
0e38325ecc1e77022640749d263c616fa2014661562526df5557240511da536a.js:1:3733
https://.../assets/plugins/retort- 
0e38325ecc1e77022640749d263c616fa2014661562526df5557240511da536a.js:1:4653
map@[native code]

Turning off Retort solves the issue. In a regular mobile browser it works fine.

Having this bug means I may have to either stop having an app or turning off Retort, neither of which are great alternatives :smiley: I’d be happy to pay to have this fixed - if that helps :slight_smile:

1 Like
#306

@DiscourseMetrics I’ve pushed a fix that I believe will fix this issue, although I have to admit not spinning up a separate app to check. Could you please pull down the account-for-missing-post branch and verify that the issue is resolved?

git clone -b account-for-missing-post https://github.com/gdpelican/retort.git
2 Likes
#308

The blank topics happens less now, so we are on the right track :slight_smile:

Now seeing these errors:

TypeError: Cannot read property 'find' of undefined
    at i.postFor (https://.../assets/plugins/retort-e5332d5fc1fdd242b0b5702995f9e863e10f7e9def1d713e49cce1c391de94ed.js:1:3337)

and

TypeError: i is undefined
Url: https://.../assets/plugins/retort-e5332d5fc1fdd242b0b5702995f9e863e10f7e9def1d713e49cce1c391de94ed.js

and

TypeError: undefined is not an object (evaluating 'i.retorts')
Url: https://.../assets/plugins/retort-e5332d5fc1fdd242b0b5702995f9e863e10f7e9def1d713e49cce1c391de94ed.js
1 Like
#309

Alright, give me a little time and I’ll have a further look into this; it seems as though the app must somehow be doing something differently than the web.

If you have a way to grant me access to the app / forum in question, that would help a lot. :slight_smile:

1 Like