Rubocop performance gem warning

Hey, @tgxworld, I’m guessing that this is on your radar, but rebuilds include this:

Post-install message from rubocop:
Performance Cops will be removed from RuboCop 0.68. Use rubocop-performance gem instead.
                                
Put this in your Gemfile.
                                                                                                                              
  gem 'rubocop-performance'     
4 Likes

Do you see that in rebuilds? Last I checked rubocop was only in development/test environments.

4 Likes

Yup. I saw that message in a rebuild on a Standard install that I did today. I started noticing it a few days ago.

5 Likes

Where are you seeing the message? I looked through the code paths where we run bundle install and those paths are correctly including --without test --without development.

5 Likes

I’ve seen it as well, this is what I’m seeing:
Untitled

5 Likes

Ouch this was a bad one. We’ve been installing test gems in production since forever.

Fixed in

https://github.com/discourse/discourse_docker/commit/b8866fb9bbda41b643dd1acf9798b230b75ddb62

https://github.com/discourse/docker_manager/commit/79aa85a88a15836ec881bb91c321978434c2f85a

We’re releasing a new base image soon to fix this issue once you rebuild.

11 Likes

Wow! I found a real problem!

Here’s a question that I should know the answer to, but don’t.

What do I watch to know when there is a new image that requires a command line upgrade?

2 Likes

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.