S3_access_key_id & s3_secret_access_key labels

(Dannii) #1

The s3_access_key_id and s3_secret_access_key labels should say they’re used for backups as well as images. And actually, maybe “images” should be changed to “attachments” (not sure about that)?

I’m posting here rather than just submitting a PR because I noticed the untranslated texts are included in a few translations, and I don’t know how you’d want to handle that.

3 Likes
(Jeff Atwood) #2

What do you think @gerhard?

(Gerhard Schlager) #3

I think those changes make sense. Feel free to create a PR.

2 Likes
(Jeff Atwood) #4

I changed it to

s3_access_key_id: "The Amazon S3 access key id that will be used to upload images, attachments, and backups."
s3_secret_access_key: "The Amazon S3 secret access key that will be used to upload images, attachments, and backups."

look OK?

4 Likes
(Dannii) #5

Looks great! Thanks.

2 Likes
(Jeff Atwood) closed #6