's3 disable cleanup' settings has a wrong description

Regardless if the checkbox for s3 disable cleanup - Disable the removal of backups from S3 when removed locally is enabled or disabled in settings, when I delete a backup locally it gets removed from the remote S3 bucket as well. I believe this is a bug, but if not please explain what am I missing. Thank you!

2 Likes

Have we checked this code path recently @gerhard?

4 Likes

It’s not a bug, but the setting description is wrong. All it does is prevent Discourse from deleting old backups from S3 when there are more backups than maximum_backups.

Backups do not work that way anymore. Depending on the value of the backup_location site setting, backups are either stored locally or on S3. When you delete a backup in the UI, it will delete that backup from local storage or S3 depending on that setting.

4 Likes

OK! I’ve edited it to

s3_disable_cleanup: "Prevent removal of old backups from S3 when there are more backups than the maximum allowed."

3 Likes