Search does not seem to work for tags with emoji

bug
1

I have tags that contain emojis, e.g. new-york-city-🇺🇸.
When using the search and advanced search, I don’t get the topics.

Here is an example:
Query:
https://urbantech-forum.cornelltech.io/search?expanded=true&q=tags%3Anew-york-city-🇺🇸subway

And here is a topic that should be returned:

1 Like
2

Not sure if this is resolvable, what is your take @neil?

3

AFAIK it’s only because the regex we have here:

https://github.com/discourse/discourse/blob/master/lib/search.rb#L583

is not allowing emojis. If this was matching on emoji, it would work after.

We might want to consider using something like: https://github.com/ticky/ruby-emoji-regex to have a good emoji regex.

what do you think @sam ?

1 Like
4

Oh my, this feels like one big monster to support for a major edge case, do we already have a validating regex on the Tag class?

1 Like
5

I don’t think we do, might be wrong though @neil probably knows better
AFAIK we just have this clean_tag function:

https://github.com/discourse/discourse/blob/master/lib/discourse_tagging.rb#L379

Which is kinda copied in client side here:

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/select-kit/mixins/tags.js.es6#L80

Also this would probably be useful at other places as we for example generate this client side: https://github.com/discourse/discourse/blob/master/app/assets/javascripts/pretty-text/emoji.js.es6#L24

2 Likes
6

I doubt that we have any tests for emoji tag names. Maybe we can look into supporting this in 2.5?

4 Likes
7

I see that the search returns only one topic when using only the tag (without the subway keyword) in the search (it’s not the topic posted in the OP):

https://urbantech-forum.cornelltech.io/search?expanded=true&q=tags%3Anew-york-city-🇺🇸

It also works with other keywords (but only for that topic returned previously):

https://urbantech-forum.cornelltech.io/search?expanded=true&q=tags%3Anew-york-city-🇺🇸%20personal

If I don’t use tags it returns correctly:

https://urbantech-forum.cornelltech.io/search?expanded=true&q=new-york-city-🇺🇸

The topic returned previously, with the tag, is the 1st returned using a keyword with the tag name, but the post is another (but it might just be because of (maybe) a metadata or something like this in the post that is caught by the search, and not the tag itself, but I can’t say for sure).