Search shortcut opens Quick Find on Firefox

Not sure if this has been covered before, but pressing / to open the search box on Discourse also opens Quick Find on Firefox. Can we change the key to something else?

Are you saying that the shortcut opens both the Discourse-internal search box and Firefox’s in-page search at the same time (which I cannot reproduce), or that Discourse hijacks the shortcut so it only opens Discourse’s internal search (which is expected behavior)?

I can reproduce that, in Firefox 46.0.1 on Ubuntu Gnome 16.04.

1 Like

Oops. Actually, I can reproduce it too, I was just looking in the wrong spot (Chrome really got me used to the top-right corner) :blush:

3 Likes

I’m on Firefox 51.0.1 (64-bit) installed on opensuse and can reproduce this bug.

Actually, quick search opens for all shortcuts :confused:

I am using Firefox nightly v57.0.a1

When I press /, both Firefox and Discourse search open.

When I press Ctrl+Shift+s, then the Firefox Webtool Debugger and the Discourse search open.

Some refactoring has been done recently though.

https://github.com/discourse/discourse/commit/889b99552aa8d5bbf61b458391f3125c31f42bb0

1 Like

ouch, did not test that this does not clash with firefox… will see if I can properly hijack it.

Why was Ctrl+Shift+s introduced? Are there any other apps using that combo for search? What about ctrl+F for find?

It came up here https://meta.discourse.org/t/how-about-mentioning-topic-feature/7350/37?u=jomaxro

Short answer, finding keyboard shortcuts that work in all browsers and all keyboards is hard!

3 Likes

I think we ended up picking ctrlaltf which seems to be holding up.

2 Likes