Shortcut for proofread text

Moin · September 13, 2024, 9:39pm

Is there also a Windows version for ⌘⌥p?
Screenshot_20240913_233816_Chrome

discourse/discourse-ai/blob/9cd14b0003700d89e1a499b9e28924ef8e1443de/assets/javascripts/discourse/components/ai-helper-options-list.gjs#L36


      
                    <li data-name={{option.translated_name}} data-value={{option.id}}>
                      <DButton
                        @icon={{option.icon}}
                        @translatedLabel={{option.translated_name}}
                        @action={{fn @performAction option}}
                        data-name={{option.name}}
                        data-value={{option.id}}
                        class="ai-helper-options__button"
                      >
                        {{#if (and (eq option.name "proofread") this.showShortcut)}}
                          <kbd class="shortcut">⌘⌥p</kbd>
                        {{/if}}
                      </DButton>
                    </li>
                  {{/if}}
                {{/each}}
              </ul>
            </template>
          }

keegan · September 13, 2024, 10:47pm

Thanks, nice catch!

I’ve got an incoming fix:

github.com/discourse/discourse-ai

FIX: Keyboard shortcut should be platform specific

discourse:main ← discourse:fix-kbd

opened 10:46PM - 13 Sep 24 UTC

keegangeorge

+7 -1

With the recent composer AI helper change (https://github.com/discourse/discours…e-ai/commit/9cd14b0003700d89e1a499b9e28924ef8e1443de), we accidentally hardcoded the keyboard shortcut string for proofreading. This PR updates that by using platform specific keys: i.e. <kbd>⌘</kbd><kbd>⌥</kbd><kbd>P</kbd> (macOS) / <kbd>ctrl</kbd><kbd>alt</kbd><kbd>p</kbd> (Windows)

Topic		Replies	Views
Improved keyboard shortcut hints on education dialog Announcements new-feature , keyboard-shortcuts	3	1139	December 1, 2023
Keyboard shortcuts wish list Feature keyboard-shortcuts	47	7824	January 18, 2018
Change hyperlink keyboard shortcut to Ctrl+k Feature keyboard , markdown-it-review , keyboard-shortcuts	4	1565	July 20, 2017
Use keyboard shortcuts, regardless of the keyboard layout Feature keyboard-shortcuts	6	2222	December 30, 2019
Feedback on the AI Helper UX ai , ai-helper	1	182	June 6, 2023

Shortcut for proofread text

Related topics