Should all plugins be cloned as the `discourse` user?

Dev
1

Is that true for all plugins, or just this one?

3 Likes
2

All plugins should clone as the user discourse, otherwise if the plugin installs gems it can have permission issues.

2 Likes
3

I totally understand that, now that you say it, but none of the plugin install instructions I have ever seen say this. Take install a plugin, for example.

Is that true for docker_manager too?

2 Likes
4

Yes this is true of everything, we should follow one pattern, PR welcome to clean stuff up.

2 Likes
5

OK. The canonical how to install a plugin topic (@erlend_sh you want to make it a wiki) and the sample yml files in discourse_docker would be good places to start.

I’ll aim to update discourse_docker stuff next time I have reason to touch it.