标签成功上传 CSV 文件后控制台中的小错误

Arkshine · 2023 年10 月 29 日 23:59

如果您上传带有标签的 CSV 文件，控制台将在成功上传后显示错误。

以下是一些调查结果。

根本问题在于，根据当前逻辑，模态框关闭得太快了。

错误发生在 uppy-upload.js 中。
由于元素（uppy-upload）已被销毁，因此属性未能设置。

这是怎么回事？ this._uppyInstance?.cancelAll();

供参考，_reset 是从 _allUploadsComplete 中调用的。

github.com/discourse/discourse

app/assets/javascripts/discourse/app/mixins/uppy-upload.js

1a78e8ec1


      
          _reset() {
            this._uppyInstance?.cancelAll();
            this.setProperties({
              uploading: false,
              processing: false,
              cancellable: false,
              uploadProgress: 0,
              filesAwaitingUpload: false,
            });

成功上传后，函数的调用顺序如下：
uploadDone → _allUploadsComplete → [ _reset ]

github.com/discourse/discourse

app/assets/javascripts/discourse/app/mixins/uppy-upload.js

1a78e8ec1


      
          this._uppyInstance.on("upload-success", (file, response) => {
            if (this.usingS3Uploads) {
              this.setProperties({ uploading: false, processing: true });
              this._completeExternalUpload(file)
                .then((completeResponse) => {
                  this._removeInProgressUpload(file.id);
                  this.appEvents.trigger(
                    `upload-mixin:${this.id}:upload-success`,
                    file.name,
                    completeResponse
                  );
                  this.uploadDone(
                    deepMerge(completeResponse, { file_name: file.name })
                  );
          
                  this._triggerInProgressUploadsEvent();
                  if (this.inProgressUploads.length === 0) {
                    this._allUploadsComplete();

当调用 uploadDone 时，模态框会立即关闭。
这意味着 uppy-upload 元素将在帧结束时被销毁。
https://github.com/discourse/discourse/blob/main/app/assets/javascripts/admin/addon/components/tags-uploader.js#L22-L26

回到 this._uppyInstance?.cancelAll();。这将触发下面的事件。
这就是它失败的原因。由于 run()，属性将在元素销毁之后设置。

github.com/discourse/discourse

app/assets/javascripts/discourse/app/mixins/uppy-upload.js

1a78e8ec1


      
          this._uppyInstance.on("file-removed", (file, reason) => {
            run(() => {
              // we handle the cancel-all event specifically, so no need
              // to do anything here. this event is also fired when some files
              // are handled by an upload handler
              if (reason === "cancel-all") {
                return;
              }
              this.appEvents.trigger(
                `upload-mixin:${this.id}:upload-cancelled`,
                file.id
              );
            });
          });

这是一个小的回归。引入于：

uppy-upload.js

github.com/discourse/discourse

DEV: Improvements to UppyUploadMixin to use ExtendableUploader

main ← dev/uppy-upload-mixin-improvements

opened 11:24PM - 05 Apr 22 UTC

martin-brennan

+131 -19

This PR brings the `UppyUploadMixin` more into line with the `ComposerUppyUpload…` mixin, by extending the `ExtendableUploader` . This also adds better tracking of and events for in progress uploads in the `UppyUploadMixin` for better UI interactions, and also opens up the use of `_useUploadPlugin` for the mixin, so anything implementing `UppyUploadMixin` can add extra uppy preprocessor plugins as needed. This has been done as part of work on extracting uploads out of the chat composer. In future, we might be able to do the same for `ComposerUppyUpload`, getting rid of that mixin to standardise on `UppyUploadMixin` and have a separate `composer-uploads` component that lives alongside `composer-editor` like what we are doing in https://github.com/discourse/discourse-chat/pull/764

github.com/discourse/discourse

FIX: Quirks around starting new uploads when one was in progress

main ← issue/improve-starting-new-uploads-progress

opened 06:48AM - 28 Sep 22 UTC

martin-brennan

+115 -42

This commit addresses issues around starting new uploads in a composer etc. when… one or more uploads are already processing or uploading. There were a couple of issues: 1. When all preprocessors were complete, we were not resetting `completeProcessing` to 0, which meant that `needProcessing` would never match `completeProcessing` if a new upload was started. 2. We were relying on the uppy "complete" event which is supposed to fire when all uploads are complete, but this doesn't seem to take into account new uploads that are added. Instead now we can rely on our own `inProgressUploads` tracker, and consider all uploads complete when there are no `inProgressUploads` in flight This is difficult to test for in JS since it involves the upload lifecycle and AJAX calls, so tests are omitted.

tags-upload.js

可能的解决方案：

稍晚关闭模态框

  uploadDone() {
    this.refresh();
    this.dialog
      .alert(I18n.t("tagging.upload_successful"))
      .finally(() => this.closeModal());
  }

将检查移出 run() 循环。

    this._uppyInstance.on("file-removed", (file, reason) => {
      // 我们专门处理 cancel-all 事件，所以不需要
      // 在这里做任何事情。当某些文件
      // 被上传处理程序处理时，也会触发此事件
      if (reason === "cancel-all") {
        return;
      }

      run(() => {

我不确定是否有更好的解决方案。所以，我在这里发帖。
对于一个非阻塞的小问题来说，文字有点多，但最初并不明显。

话题		回复	浏览量
Tag upload with special characters via CSV is failing Support	13	1261	2020 年6 月 15 日
Error while uploading tags: 'hijack tags upload ' is still running after 90 seconds Support	0	233	2022 年7 月 29 日
Selectable avatars upload broken (Missing required UppyUpload config: id) Bug	12	205	2024 年11 月 2 日
Remove "Uploading..." from a newly created / edited post Feature	2	1093	2016 年7 月 6 日
Cannot upload images with Safari Bug	32	2869	2023 年5 月 24 日

标签成功上传 CSV 文件后控制台中的小错误

相关话题