Certains profils d'utilisateur envoient maintenant des résumés par email toutes les 30 minutes après la mise à jour

zogstrip · Mai 27, 2024, 3:38

There was indeed an issue with the way we computed the “window” we used to compute the content of the email summaries

It will be fixed by

github.com/discourse/discourse

FIX: correctly compute the window for email summaries

discourse:main ← discourse:fix-digest-since

opened 03:35PM - 27 May 24 UTC

ZogStriP

+25 -1

In https://github.com/discourse/discourse/commit/958437e7ddce6e015725522d25c3f83…27ff4064a we ensured that the email summaries are properly sent based on 'digest_attempted_at' for people who barely/never visit the forum. This fixed the "frequency" of the email summaries but introduced a bug where the digest would be sent even though there wasn't anything new since for some users. The logic we use to compute the threshold date for the content to be included in the digest was ```ruby @since = opts[:since] || user.last_seen_at || user.user_stat&.digest_attempted_at || 1.month.ago ``` It was working as expected for users who were never seen but for users who had connected at least once, we would use their "last_seen_at" date as the "threshold date" for the content to be sent in a summary 😬 This fix changes the logic to be the most recent date amongst the `last_seen_at`, `digest_attempted_at` and `1.month.ago` so it's correctly handling cases where - user has never been seen nor emailed a summary (capped at 1 month) - user has been seen in a while but has recently been sent a summary - user has been sent a summary recently but hasn't been seen in a while Context - https://meta.discourse.org/t/some-user-profiles-now-email-summaries-every-30-minutes-after-update/309485

Sujet		Réponses	Vues
Activity summaries not sent to a particular user Support activity-summary	4	643	Avril 10, 2021
Discourse Activity Summaries for New Users Created via API Dev activity-summary	11	1604	Août 29, 2017
Can Admin send "Daily Updates" or "Activity Summary" to specific users/email addresses? Support activity-summary	2	659	Juin 8, 2024
Email Digest Preferences duplicated Bug activity-summary	3	1317	Mai 26, 2016
Need to confirm that digest mails are being sent Support activity-summary	13	1184	Août 11, 2023

Certains profils d'utilisateur envoient maintenant des résumés par email toutes les 30 minutes après la mise à jour

Sujets connexes