n1bff
October 30, 2023, 11:09pm
1
Users cannot register new accounts in my forum.
After filling out the signup form and clicking “Create your account”, the modal dialog gets a red header bar with the message
Something went wrong, perhaps this email is already registered, try the forgot password link
This happens with any mail address. I have no blocked email domains.
The browser’s network log shows a request to https://example.com/u receiving a 400 error and the response {"errors":["param is missing or the value is empty: email"]}
https://example.com/logs/ shows nothing remotely related I think, maybe some Job exception: Net::SMTPServerBusy errors from 3 hours ago.
5 Likes
I can reproduce as well.
There is a regression in this PR from yesterday.
discourse:main ← discourse:0-awesome-create-account
opened 04:17PM - 25 Oct 23 UTC
plugin/theme-breaking changes:
1. `controller:create-account` is gone (use `c… omponent:modal/create-account` in modifyClass, **if** absolutely necessary)
2. `create-account-body` css class is gone (target `.d-modal.create-account` or any of the inner classes: `.modal-outer-container`, `.modal-middle-container`, `.modal-inner-container`, or `.modal-body`)
The issue is here:
In performAccountCreation(), attrs for name, email, and username contain properties name with model. and is passed to User.createAccount(attrs).
const attrs = this.getProperties(
"model.accountName",
"model.accountEmail",
"accountPassword",
"model.accountUsername",
"accountChallenge",
"inviteCode"
);
attrs["accountPasswordConfirm"] = this.accountHoneypot;
const userFields = this.userFields;
const destinationUrl = this.get("model.authOptions.destination_url");
if (!isEmpty(destinationUrl)) {
cookie("destination_url", destinationUrl, { path: "/" });
}
// Add the userFields to the data
if (!isEmpty(userFields)) {
show original
However, createAccount is not expecting that, resulting in empty data.
createAccount(attrs) {
let data = {
name: attrs.accountName,
email: attrs.accountEmail,
password: attrs.accountPassword,
username: attrs.accountUsername,
password_confirmation: attrs.accountPasswordConfirm,
challenge: attrs.accountChallenge,
user_fields: attrs.userFields,
timezone: moment.tz.guess(),
6 Likes
CvX
October 31, 2023, 12:57am
3
8 Likes
n1bff
October 31, 2023, 8:37am
4
Thanks, upgrading fixed it.
3 Likes
Just for reference, Jarek fixed it heren thanks!
discourse:main ← discourse:0-regression
opened 12:54AM - 31 Oct 23 UTC
Regressed in 351cbab1a8568c06e138cf5d31fa66552c3ef352
1 Like
This topic was automatically closed after 23 hours. New replies are no longer allowed.
