Situaciones espeluznantes đŸ‘»

Llevo meses notando cosas como las siguientes, pero nunca he presentado un informe porque nunca pude reproducirlas de forma consistente. Pero, por fin, por accidente, ÂĄlas he capturado en cĂĄmara! (AsĂ­ que por favor disculpen las pausas y la confusiĂłn reflejadas en los movimientos de mi cursor).

Las cosas a las que hay que prestar atenciĂłn son:

  1. Que la pestaña de No leídos esté vacía
  2. Que Contribute > Feature aparezca como ‘Normal’ (a pesar de estar rastreado, como se muestra en mis preferencias) y solo se muestre como ‘Rastreado’ despuĂ©s de actualizar la pĂĄgina
  3. Que un tema aparezca misteriosamente en no leĂ­dos (de hace dĂ­as, de la categorĂ­a howto)

El segundo punto es algo similar a un error comĂșn que veo (pero que nunca he podido reproducir en vĂ­deo) donde hago clic en un tema desde nuevos en una categorĂ­a que estoy rastreando, pero su propio estado no se muestra como rastreado a menos que actualice la pĂĄgina. (Me pregunto si eso estĂĄ relacionado con esto.)

Justo antes de grabar esto, estaba intentando reproducir ese error rastreando Contribute > Bug y luego haciendo clic en uno de sus temas desde la pestaña de no leídos. No pude, pero al dejar de rastrear Contribute > Bug, mi pestaña de no leídos se llenó con unos 20 temas cerrados en Contribute > Bug de alrededor de 2015, lo que parece ser el mismo error que el punto 3.

No entiendo por qué podría estar ocurriendo esto. :ghost:

2 Me gusta

What are the repro steps?

1 me gusta

There are two bugs here.

I can’t consistently reproduce the first, where the correct notification level is only shown after a refresh (of a category, or a topic). It’s been happening to me for months, but whenever I try to reproduce it, it doesn’t happen.

The second, which I think is a bit more minor, but still a nuisance can be reproduced (for a limited time only) like so:

  1. Clear /unread
  2. Track a category currently set to ‘Normal’
  3. Go back to /unread and observe posts not previously in it

I’ve been able to do this with a number of categories, but only once for each. Once I’ve dismissed the posts from unread, they never appear again.

Consistently reproducing it takes a little more work, so hold onto your hats, it’s gonna get a bit crazy:

  • Go to unread in a category of your choosing which has a notification level of “Normal”, observe nothing there:

  • List all the currently tracked topics in that category (and remember, or take a screenshot of them):

  • Enter a topic from that category not on that list:

  • Start tracking the category
  • Again list tracked topics in that category
  • Observe the topic you just opened in that list:

  • Go to unread, and again observe that topic in the list:


TL;DR

So, the bug here is that previously opened topics in a category become tracked, and appear in unread (unless previously dismissed), when the category is tracked, whereas nothing happens to old not-opened-before topics.

To me, what should happen is either:

  • Nothing changes about the notification status of old topics in a category when it becomes tracked, previously opened or not.

or

  • All old topics become tracked when the category is tracked, but are automatically dismissed, so only new activity appears in the unread tab.

I lean towards the second solution, provided explicitly set notification levels on topics are kept.

I haven’t investigated how this works with other notification levels, I imagine its the same, but I feel it would confuse things for the time being.

So in relation to

What part is considered as “not working as expected”?

1 me gusta

2 partes:

La primera serĂ­a que los temas no se estĂĄn rastreando correctamente de forma implĂ­cita. Si asĂ­ fuera, todos los temas de Community Building > Praise deberĂ­an aparecer en este paso:

Parece que esa lista solo muestra los temas con un registro de seguimiento de “rastreado”, y eso no funciona segĂșn lo esperado. Lo que deberĂ­a ocurrir es mostrar todos los temas con un registro de seguimiento de “rastreado”, y todos los temas que pertenecen a una categorĂ­a rastreada. (Lo mismo aplicarĂ­a para la funciĂłn de “seguir”).

AdemĂĄs, aunque tiene sentido:

Parece que falta la misma funcionalidad cuando un usuario rastrea una categoría. ¿No debería crearse también un registro de seguimiento cuando hay una nueva publicación en un tema?

La segunda sería la aparición de temas aparentemente arbitrarios como no leídos cuando rastreas una categoría (asumo que es un efecto secundario del cambio de estado de seguimiento de temas anteriores de “regular” a “rastreado”), lo cual podría solucionarse descartando automáticamente esos temas como no leídos.

What are your Preferences → Other
Consider topics new when
and
Automatically track topics I enter
settings?

I haven’t viewed them yet

never

1 me gusta

Esto es algo que encontré hace un tiempo, y se puede encontrar un hilo aquí (no estoy totalmente seguro de por qué se movió de Contribute > Bug a Contribute > Feature).

El hilo es bastante confuso porque originalmente pensé que el problema era causado por la importación inicial desde phpBB. Así que aquí va un intento de resumir:

Se reduce al hecho de que un tema no puede ser simultĂĄneamente nuevo y no leĂ­do:

  • Aunque estĂĄ implĂ­citamente rastreado, el tema no aparece en no leĂ­dos porque el usuario nunca lo ha visto
  • El tema no aparece en nuevo porque estĂĄ mĂĄs allĂĄ del umbral de tu configuraciĂłn “Considerar temas nuevos cuando”

Es un problema difĂ­cil de resolver, porque que todos los temas antiguos de una categorĂ­a aparezcan en tu pestaña de ‘no leĂ­dos’ realmente no es una buena experiencia de usuario.

“Descartarlos automáticamente” es bastante costoso a nivel de base de datos (se tendría que crear un nuevo registro TopicUser para cada tema en la categoría que acabas de rastrear).

Realmente no llegamos a una idea ordenada para resolver el problema, y la discusiĂłn se enfriĂł. Una opciĂłn que @sam propuso fue

En ese momento, pensé que esto podría ser una buena idea:

Pero

TL;DR: No tengo una soluciĂłn, pero espero que esto aclare el problema :wink:

3 Me gusta

And for the other issue in this thread:

I can reproduce this consistently here on meta for categories. Repro steps:

  1. Go to your user preferences, remove all tracked categories
  2. Go to a category page, e.g. #meta, and observe that the ‘notification level’ indicator is “normal”
  3. Go immediately to your user preferences, by clicking your avatar in the top right, then the cog
  4. Add the category you just visited, e.g. #meta, to your “tracking” categories
  5. Press “save changes”
  6. Press the back button in your browser to return to #meta, and observe that the ‘notification level’ indicator is still “normal”
  7. Refresh the page, and observe that the ‘notification level’ is now “tracked”

If you replace step 6 with visiting the category page by some other route, the tracking status appears correctly.

5 Me gusta

From a practical perspective, that doesn’t make sense to me. If I buy a book and put it on my shelf having not opened it, it is both new and unread.

Wouldn’t it be possible to have an old topic (with no tracking record) only appear in unread when there’s new activity on it?

So, just as a tracking record is created on new activity for topics in watched categories, a tracking record would be created on new activity for topics in tracked categories.

Combined with the above, couldn’t we just dismiss topics where the tracking record has been changed to “tracking” as a result of tracking the category, which would mean the same user experience, without any additional database writes? (If I understand how tracking records, dismissing and TopicUser relate.)

This way, it seems to me, we could have a mailing list experience for tracking too! :smile:

Sure, I agree. I was talking purely about how it currently works in discourse.

I believe @sam thought this would have major performance issues

I’m 99% sure a new record isn’t created for tracked topics - @sam said “created when we notify users”, and tracking doesn’t cause notifications. Maybe fixing this is the solution :slight_smile:

1 me gusta

Do you know if there’s an architectural issue which means the new/unread either/or has to be the case?

Indeed, I was proposing this as a solution which seems to not have any major performance issues.

1 me gusta

I assume it’s by design - having a topic listed on the new tab and the unread tab would be a bit weird.

Taking your book analogy, while it can be both unread and new, you can’t put it on your “new” shelf and your “unread” shelf simultaneously :wink:

4 Me gusta

Ok
 I’ve done some testing in my dev environment. As a simplest possible repro:

  1. Set previous visit timeout hours site setting to 0, to make testing quicker
  • User A sets “Consider topics new when” to “created since I was last here”
  • User A sets Category1 to tracked
  • User B posts in Category1
  • User A observes the topic in ‘new’, but does not open it
  • User A leaves the site
  • User A comes back to the site later, and User B’s post is gone from the ‘new’ tab
  • User B posts again in the same topic
  • The topic does not appear in either ‘new’ or ‘unread’ for User A, even though they are tracking the topic

That same repro works for ‘watching’ a category as well. A notification is sent, but no TopicUser row is created (checked on the rails console). It seems that this:

is not happening for some reason, both for watched and tracked categories.

1 me gusta

Would it though? We already have topics listed in the latest tab and the new/unread tabs simultaneously. And the two (new and unread) are for different purposes: new is “show me the newest topics on this site” and unread is “show me topics I’ve expressed an interest in, but haven’t (finished) read(ing)”. For new to achieve its purpose it has to have unread topics in it which are new, and for unread to achieve its purpose it needs to have new topics in it which are unread.

Currently the unread tab is rather dysfunctional.

Interesting, thanks for doing all this investigation! So it would seem like if this did actually happen (or more specifically, a TopicUser row was created on topic update, rather than notification, to include tracked categories), then our problems here would be solved. @sam thoughts?

I am fine to change the semantics of “tracked category” so it means, if a category is tracked it will unconditionally show up in new regardless of your new duration, it does not mean this now.

4 Me gusta