bartv
(Bart )
December 9, 2018, 10:49am
1
Hi,
We just noticed that the subcategories dropdown list now only has a ‘none’ option where it used to also have an ‘all’ option.
Here’s what it looks like now:
Here’s what it looks like on an older installation:
While ‘all’ is still the default value, you can’t return to it after diving into a subcategory, making navigation a little harder. Is this on purpose, or a bug?
2 Likes
jomaxro
(Joshua Rosenfeld)
December 9, 2018, 2:23pm
2
Good catch, don’t think this is intentional. If you need to get to “all” you can select “none” first, then reopen the filter.
cc @joffreyjaffeux
2 Likes
This should fix it, it also introduces tests for category-drop
:
https://github.com/discourse/discourse/pull/6743
Will think more about it and maybe improve it more and push it Monday.
7 Likes
jomaxro
(Joshua Rosenfeld)
December 10, 2018, 3:12pm
5
Looking good to me, thanks @joffreyjaffeux . All set here @bartv ?
2 Likes
bartv
(Bart )
December 10, 2018, 8:27pm
6
Yep, it works fine for me too. Thanks for the quick solution everyone!
3 Likes