Its a general dev practice to add a newline at the end of the file as github always complains about it. My suggestion is to enable the eol-last rule for eslint and ember-template-lint. I see this code here which has it under a comment.
Thoughts @riking ?
Oops, I forgot about that one!
I put rules that had too many violations / diffs as “pending” while working on that file. So the way to see the explanation is to enable it and see what gets changed.
There were only a handlful of errors, so I ended up fixing them and making a PR.
Also, Am I correct in thinking that the CI used the updated config to run the checks?
https://github.com/discourse/discourse/pull/12678