Support merging of 2 topics with voting


(Allen - Watchman Monitoring) #1

I had people two topics in a voting category which were essentially the same request, so I merged all comments from Topic B to Topic A, and now Topic A has no votes.

Has anyone seen an issue where votes on Topic A are lost/reset after moving a number of commits into it from Topic B?

I think I did, but don’t know if there’s any place I can tell if a Topic A ever got votes. If they were logged anywhere, I’d love to know so I can check.

Discourse Voting
(Sam Saffron) #2

Agree we should fix this, for now #pr-welcome

(Dan Ungureanu) #3


This PR should fix this.

Let’s say we have topics A and B. When topic A is merged into topic B, all users who voted topic A will automatically vote B and their votes for A will be removed.

(Alex Sherwood) #4

Are there any exceptions to this rule? I’ve noticed some inconsistent behaviour e.g. when I merged this topic:

Let users specify number of shares while buying - Feedback and Ideas ☝️ - Freetrade Community

into this one:

Buy an specific number of shares rather than a £ amount - Feedback and Ideas ☝️ - Freetrade Community

not all of the votes were carried across the latter topic. IIRC only 16 made it across.