"Suppress these tags from summary emails" settings is not working in preview digest email?

th21 · September 15, 2023, 11:34pm

I excluded some tags in the new settings and try to preview the digest email, the preview contains some duplicated topics, and topics with those tags are also included.

simon · September 16, 2023, 1:21am

Testing this on my local dev site, it seems to be a bug. The code is expecting the digest_suppress_tags setting to be a pipe delineated list of tag ids, but it’s actually a list of tag names:

github.com

discourse/discourse/blob/main/app/models/topic.rb#L592


      
            topics =
              topics.where(
                "topics.category_id NOT IN (?)",
                SiteSetting.digest_suppress_categories.split("|").map(&:to_i),
              )
          end
          if SiteSetting.digest_suppress_tags.present?
            topics =
              topics.joins("LEFT JOIN topic_tags tg ON topics.id = tg.topic_id").where(
                "tg.tag_id NOT IN (?) OR tg.tag_id IS NULL",
                SiteSetting.digest_suppress_tags.split("|").map(&:to_i),
              )
          end
          remove_category_ids << SiteSetting.shared_drafts_category if SiteSetting.shared_drafts_enabled?
          if remove_category_ids.present?
            remove_category_ids.uniq!
            topics =
              topics.where(
                "topic_users.notification_level != ? OR topics.category_id NOT IN (?)",
                TopicUser.notification_levels[:muted],
                remove_category_ids,

Here’s what the setting looks like on my site:

SiteSetting.digest_suppress_tags
=> "foo|bar"

The code that’s excluding the tags from the digest is expecting the setting’s value to be "1|2" (the tag ids.)

Note that the digest_suppress_categories setting works without any issue. The settings category-selector saves category ids, not category names.

Osama · September 19, 2023, 8:20am

This is now fixed in:

github.com/discourse/discourse

FIX: Parse the digest_suppress_tags setting correctly (#23623)

committed 07:45AM - 18 Sep 23 UTC

OsamaSayegh

+10 -6

Meta topic: https://meta.discourse.org/t/suppress-these-tags-from-summary-emails…-settings-is-not-working-in-preview-digest-email/279196?u=osama Follow-up to https://github.com/discourse/discourse/commit/477a5dd371e9605a0c0058d0805c767c77fa7c93 The `digest_suppress_tags` setting is designed to be a list of pipe-delimited tag names, but the tag-based topic suppression logic assumes (incorrectly) that the setting contains pipe-delimited tag IDs. This mismatch in expectations led to the setting not working as expected. This PR adds a step that converts the list of tag names in the setting to their corresponding IDs, which is then used to suppress topics tagged with those specific tags.

Thank you for the report @th21 and for the great analysis/debugging @simon!

Topic		Replies	Views
Suppressed category included in digest bug activity-summary	4	567	September 16, 2023
What are some simple ways to improve digest emails feature activity-summary	29	8685	January 5, 2017
Activity Summary not sent if other emails are sent feature email , activity-summary	16	478	April 2, 2024
Limiting tags to categories not working as expected bug tags	9	688	May 24, 2023
Please restore email digests feature	47	6521	June 20, 2017

"Suppress these tags from summary emails" settings is not working in preview digest email?

Related Topics