Tab notifications not clearing

@Slowhand could you please test a theory? I believe this only happens for people who enabled Show counts on browser icon in their profile settings. Can you try disabling it and seeing if this goes away?

7 Likes

I can confirm that’s the case. The tab count notification behaves as expected when Show counts on browser icon is unchecked.

On a normal (unpinned tab) with Show counts on browser icon unchecked:
Screen Shot 2020-10-07 at 1.38.34 PM

No count when the tab is pinned:
Screen Shot 2020-10-07 at 1.38.56 PM

Compare to when Show counts on browser icon is checked:
Screen Shot 2020-10-07 at 1.41.57 PM
Screen Shot 2020-10-07 at 1.41.40 PM

5 Likes

Took me a bit to finally get some notifications, apparently Wednesday afternoon isn’t a great time to test.

But I can confirm that it’s working properly. I get notifications and when I click on the tab they disappear.

I had two tabs open so I could get a screenshot.

image

5 Likes

Great I can repro it when using the icon thing, will take a look.

9 Likes

This should do

https://github.com/discourse/discourse/pull/10875

9 Likes