ondrej
September 8, 2023, 6:49pm
1
I was just looking though @JammyDodger 's posts fishing for an previous reply and I noticed that unlike in topics (2 ) in your activity (1 ) the square defining the category colour is missing.
1
2
(Funky topic title courtesy of Discourse AI
6 Likes
I think I spotted a missing one on published pages too:
2 Likes
I believe the ones on the activity page are now fixed
discourse:main ← discourse:issue/hashtag-icons-user-activity-list
opened 01:45AM - 27 Oct 23 UTC
This was just a case of removing the `onlyStream: true`
operation from `decorat… eCookedElement`, since that restricts
the decoration only to topic page posts.
Before
After
1 Like
martin
November 2, 2023, 1:45am
7
I just merged a fix for this:
discourse:main ← discourse:issue/hashtags-on-embed-and-publish
opened 01:32AM - 02 Nov 23 UTC
Since we don't have icons or access to the JS that transforms
hashtag icon plac… eholders into their proper icons and colours
on embed and publish pages, we need to at least show _something_
and make sure the hashtags are not totally broken on these pages.
Not ideal, but it would be a lot of effort to make this show the correct
thing.
It’s not perfect, but it would be quite complicated to get the icons and colours working on this standalone page because it doesn’t have access to icons or category or tag data. At the least, it’s not completely broken like it was before.
martin
November 10, 2023, 6:28am
12
I had one more fix for this here this week:
discourse:main ← discourse:issue/fix-hashtag-render-in-activity-stream
opened 04:21AM - 07 Nov 23 UTC
Followup to 545e92039c7e7f45e72274773ea39e7d2df94ded
This commit fixes an iss… ue where hashtags on user activity stream
items past page 1 did not get decorated. This is because of a bug
in the user stream component, where it was trying to get stream
items to decorate after the AJAX call but before they had been
rendered by Ember. This can be fixed by wrapping this decoration
logic in later() to run on the next runloop.
2 Likes
)
