Thumbnails missing when using the Minima theme

mpaler · October 4, 2023, 8:15pm

Having a problem with this theme component, and not really sure where to begin debugging it? I’m posting here in hopes of someone having a simple solution…

I’m using the Minima theme by @awesomerobot, and have this component installed and included with the theme. From the preview link in the component, it all looks good:

However, the live site, the images are missing:

Any suggestions are greatly apprciated!

Firepup650 · October 13, 2023, 9:13pm

Those images render fine for me while being logged out, mobile view Android 13 Samsung Galaxy A23.
However it breaks once loaded in desktop view.

Lilly · October 13, 2023, 9:24pm

~~I think there is another component trying to override the same topic-list-item.hbr template in desktop mode.~~

Arkshine · October 13, 2023, 9:25pm

That’s because the topic list items template is modified for desktop only.
The issue of missing images is because it misses the outlets.

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/raw-templates/list/topic-list-item.hbr

{{~raw-plugin-outlet name="topic-list-before-columns"}}

{{#if bulkSelectEnabled}}
  <td class="bulk-select topic-list-data">
    <label for="bulk-select-{{topic.id}}">
      <input type="checkbox" class="bulk-select" id="bulk-select-{{topic.id}}">
    </label>
  </td>
{{/if}}

{{!--
  The `~` syntax strip spaces between the elements, making it produce
  `<a class=topic-post-badges>Some text</a><span class=topic-post-badges>`,
  with no space between them.
  This causes the topic-post-badge to be considered the same word as "text"
  at the end of the link, preventing it from line wrapping onto its own line.
--}}
<td class='main-link clearfix topic-list-data' colspan="1">
  {{~raw-plugin-outlet name="topic-list-before-link"}}
  <span class='link-top-line'>

This file has been truncated. show original

Especially the first outlet which is used by Topic Thumbnail to insert the image.

Lilly · October 13, 2023, 9:27pm

@mpaler you should update your Discourse instance to 3.2.0.beta2-dev

content="Discourse 3.2.0.beta1-dev

Ed_S · October 14, 2023, 9:31am

Hmm, today I learned the exact Discourse revision is recorded in the HTML of every page…

Lilly · October 14, 2023, 6:57pm

FYI if you aren’t already aware you can also match up these version numbers to make sure you are on a latest commit:

Admin Dashboard, current install version

dashboard_version

Meta tag in most Discourse forum pages

Github Discourse (dashboard links to this so you can check if this is the latest commit)

Lilly · October 14, 2023, 9:49pm

btw @mpaler The component and site appear to be working for me now in Chrome desktop and Safari desktop and mobile, logged in or out.

Arkshine · October 14, 2023, 10:28pm

I forgot to mention that the issue was resolved in the marketplace topic he made.

Lilly · October 14, 2023, 10:42pm

Oh didn’t see that. Nice work!

system · November 13, 2023, 10:42pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.