sam
(Sam Saffron)
July 20, 2015, 11:56pm
1
New Release - Firmware Version 1.02.06 for My Book World Edition I & II (1/4/2011)
Is rendered as:
The magic shanaigens should only happen if there is a space between it and other words… EG:
Sam and a 1/4
should get quarter magic
Sam was born 1/4/2001
should get no quarter magic.
1 Like
I believe this is a default SmartyPants implementation, not our implementation. So the bug might be upstream for existing Ruby code…
The fix is clearly to convince the entire world to using proper (iso 8601) dates. Everything else is just stopgapping.
riking
(Kane York)
July 21, 2015, 2:39am
4
Yes, but I daresay there will be more topics about April 1st…
3 Likes
sam
(Sam Saffron)
July 22, 2015, 6:42am
5
1 Like
Yeah, because David/Gene/Edward does seem like a word break to me. You could specialize it to numbers and say a slash between numbers is not a word break.
sam
(Sam Saffron)
July 22, 2015, 6:55am
7
fixed via
vmg:master
← SamSaffron:master
opened 06:54AM - 22 Jul 15 UTC
special handling for 1/4/2000 in smartypants
waiting for it to be accepted
we are carrying a lot of GEM around for this 1 c file out of the 20 it ships
2 Likes
sam
(Sam Saffron)
September 16, 2015, 7:03am
8
Change is accepted, waiting on a stable release
2 Likes
sam
(Sam Saffron)
September 24, 2015, 3:39am
9
This is now fixed per:
https://github.com/discourse/discourse/commit/ffb8cb8caca2f0b73c480b96a2b753ef5866a91e
We no longer ship the Redcarpet gem, we have a pure Ruby implementation of title prettify that is included in our code base.
Before:
After:
We no longer have to wait months for title prettify fixes.
8 Likes