sam
July 20, 2015, 11:56pm
1
New Release - Firmware Version 1.02.06 for My Book World Edition I & II (1/4/2011)
Is rendered as:
The
Sam and a 1/4 should get quarter magicSam was born 1/4/2001 should get no quarter magic.
1 Like
I believe this is a default SmartyPants implementation, not our implementation. So the bug might be upstream for existing Ruby code…
The fix is clearly to convince the entire world to using proper (iso 8601) dates. Everything else is just stopgapping.
riking
July 21, 2015, 2:39am
4
Yes, but I daresay there will be more topics about April 1st…
3 Likes
sam
July 22, 2015, 6:42am
5
Raised:
opened 06:39AM - 22 Jul 15 UTC
closed 01:27PM - 22 Jul 15 UTC
why all the hate for the 1 of April :smile:
```
[11] pry(main)> Redcarpet::Ren… der::SmartyPants.render("1/4 a year ago on 1/4/2010 something happened")
=> "¼ a year ago on ¼/2010 something happened"
```
should be
```
=> "¼ a year ago on 1/4/2010 something happened"
```
there should be a bypass if the char after the fraction is `/` which is punctuation but not in that context
the bug is here:
return 0;
}
// Converts 1/2, 1/4, 3/4
static size_t
smartypants_cb__number(struct buf *ob, struct smartypants_data *smrt, uint8_t previous_char, const uint8_t *text, size_t size)
{
if (fraction_boundary(previous_char) && size >= 3) {
if (text[0] == '1' && text[1] == '/' && text[2] == '2') {
if (size == 3 || fraction_boundary(text[3])) {
BUFPUTSL(ob, "½");
return 2;
}
}
if (text[0] == '1' && text[1] == '/' && text[2] == '4') {
if (size == 3 || fraction_boundary(text[3]) ||
(size >= 5 && tolower(text[3]) == 't' && tolower(text[4]) == 'h')) {
BUFPUTSL(ob, "¼");
return 2;
}
In particular word boundary is defined as: isspace(c) || ispunct(c); , ispunct includes /
1 Like
Yeah, because David/Gene/Edward does seem like a word break to me. You could specialize it to numbers and say a slash between numbers is not a word break.
sam
July 22, 2015, 6:55am
7
fixed via
master ← SamSaffron:master
merged 01:27PM - 22 Jul 15 UTC
special handling for 1/4/2000 in smartypants
waiting for it to be accepted
we are carrying a lot of GEM around for this 1 c file out of the 20 it ships
VIDEO
2 Likes
sam
September 16, 2015, 7:03am
8
Change is accepted, waiting on a stable release
2 Likes
sam
September 24, 2015, 3:39am
9
This is now fixed per:
committed 03:37AM - 24 Sep 15 UTC
PERF: cache fancy_title in topics table
New pure ruby implementation is far mor… e flexible and easier to amend.
We no longer ship the Redcarpet gem, we have a pure Ruby implementation of title prettify that is included in our code base.
Before:
After:
We no longer have to wait months for title prettify fixes.
8 Likes
magic shanaigens should only happen if there is a space between it and other words… EG:
