Toggle Whisper šŸ‘

Theme component
28

Sorted. This is now with the original author who can take this forward.

2 Likes
29

Thanks for sorting that out. :pray: :slight_smile:

3 Likes
30

@ganncamp
Iā€™ve fixed the immediate issue. Thereā€™s one caveat though. Currently the Discourse backend only supports staff users to be able to switch a postā€™s post_type so I have made the :eye: toggle icon to to appear if a user is in whispers_allowed_groups and also a staff member. Do let us know your thoughts on this.

3 Likes
31

I appreciate the effort. I came up with came up with a solution which reduces the complexity a bit. Also thanks for pointing out the actual cause.

2 Likes
32

Thatā€™s fine for us; only staff can see whispers.

Andā€¦ Iā€™m not seeing this on my instance yetā€¦?

1 Like
35

And now it works! Thanks!

2 Likes
36

image
Breaking change on new version of discourse

5 Likes
39

I recently ran into the same problem as well, so I rewrote the component and made a PR. Pull requests Ā· fzngagan/discourse-toggle-whisper

@fzngagan Can you take a look at it?

11 Likes
40

Just tested it and it works like a charm. The code looks nice too. Thanks so much for this, it save me a bunch of work. Merged :tada:

5 Likes
41

image
image1288Ɨ125 4.04 KB

It does have some issues though, when not logged in.

it causes much more than just 1 error also.

3 Likes
42

I made a quick PR to fix the issue :+1: (@fzngagan)

5 Likes
43

Nice one! i love codingā€¦ a simple ? and the problem is solved :joy:

image
image415Ɨ189 2.35 KB

3 Likes
44

The toggle whisper icon is not appearing on our site anymore, we are running on 3.4.1. Anyone else having same issue?

45

@fzngagan heads up on a 404 link here:

Screenshot 2025-05-29 at 09.59.57
Screenshot 2025-05-29 at 09.59.571348Ɨ1148 82.1 KB

46

Thereā€™s a potential leak here whereby some users can still visibly see the whispered posts.

Steps to replicate:

  1. Without whispering, reply direct to or quote a user in a post/reply
  2. Change the post to a whisper
  3. The @mentioned / @quoted user can still visibly see the whispered post
47

I donā€™t think I can repro that?

My step by step just to see if Iā€™m doing a :derp:

  • Test_One creates post by directly replying to Test_Two
  • Also throws in a quote of Test_Three and an @mention of Test_Four
  • As admin, toggle that post into a whisper

The only people who can see the whisper are Admin and Test_One (which is expected, as you can see your own whisper posts even after you can no longer create whispers) [this has since been fixed see below]

Is it a page refresh thing?

1 Like
48

Iā€™ll check with my colleague who reported the issue to confirm, but:

Is Test_One an admin? :thinking:

49

No, just a normal non-staff user.

Does it need to be an admin and/or mod?

ETA: re-running the test using an admin to create the direct reply (with quote + mention) seems to be offering similar results.

There is a ux oddity in that each of these test users got a notification for the respective things, and when followed the post was no longer there for them to see.

Thereā€™s also another ux one for the expandable ā€˜x repliesā€™ box where the count includes the whisper, but doesnā€™t show it when expanded.

1 Like
50

Unsure, weā€™ll do some more testing and report back, thanks :smiley:

1 Like
51

This is now no longer the case :tada:

5 Likes