Toggle Whisper 👁

[merefield (Robert)]

Sorted. This is now with the original author who can take this forward.

[JammyDodger]

Thanks for sorting that out.

[fzngagan (Faizaan Gagan)]

@ganncamp
I’ve fixed the immediate issue. There’s one caveat though. Currently the Discourse backend only supports staff users to be able to switch a post’s post_type so I have made the toggle icon to to appear if a user is in whispers_allowed_groups and also a staff member. Do let us know your thoughts on this.

[fzngagan (Faizaan Gagan)]

I appreciate the effort. I came up with came up with a solution which reduces the complexity a bit. Also thanks for pointing out the actual cause.

[ganncamp (G Ann Campbell)]

@fzngagan

Currently the Discourse backend only supports staff users to be able to switch a post’s post_type so I have made the toggle icon to to appear if a user is in whispers_allowed_groups and also a staff member.

That’s fine for us; only staff can see whispers.

And… I’m not seeing this on my instance yet…?

[ganncamp (G Ann Campbell)]

And now it works! Thanks!

[Fma965]

Breaking change on new version of discourse

[Lhc_fl (Linca)]

I recently ran into the same problem as well, so I rewrote the component and made a PR. Pull requests · fzngagan/discourse-toggle-whisper

@fzngagan Can you take a look at it?

[fzngagan (Faizaan Gagan)]

Just tested it and it works like a charm. The code looks nice too. Thanks so much for this, it save me a bunch of work. Merged

[Fma965]

It does have some issues though, when not logged in.

it causes much more than just 1 error also.

[Arkshine]

I made a quick PR to fix the issue (@fzngagan)

FIX: A rendering error with guest user

[Fma965]

Nice one! i love coding… a simple ? and the problem is solved