'Top' sorting always defaults to Year time period

[P16]

I’m not sure if this is a bug, but whenever I visit /Top, the time period selected by default is always the past year. From what I have read on Meta, it should select the time period based on your last visit - i.e. if you haven’t visited Meta in a few days, it shows the past week; likewise, if you visited it yesterday, you should be shown the Top posts for the past 24 hours.

[codinghorror (Jeff Atwood)]

Possibly but I am not sure we did this on manual navigation to top, it is more of a redirect for long absent users. Perhaps @zogstrip can advise.

[zogstrip (Régis Hanol)]

Turns out, this was broken since we added support for a default top timeframe. That value was overriding the date of the user’s previous visit instead of just being a default value when there was no previous visit (new user or anon).

https://github.com/discourse/discourse/commit/33bc8c276d8db36513adf72a863db3d648613489

While at it, I noticed another bug where a returning user would not be redirected to the proper timeframe due to a variable not being named properly on the client-side…

https://github.com/discourse/discourse/commit/b792db9d92dedd5bcd9386f4169fb6c4ee1b55aa

Thanks @P16 for the report as we got to fix 2 bugs

[P16]

Thanks @zogstrip for fixing this! Just to confirm, is the correct behavior to default to the most relevant time period, even if /top is selected manually?

While on this topic, are you still open to suggestions for the Top sorting criteria, as the original topic has closed:

Improving the "Top" criteria

The top page in Discourse is intended for two cases It is where new users are directed after they join the site, and where existing users are directed after long absences from the site. The idea is that we show people the “greatest hits” of the community when they arrive, whether it is the last year, or the last month. When you want to catch up with a busy Discourse and skim just the most interesting / useful / active topics. Sort of like the summarize topic option, but at the topic list l…

[zogstrip (Régis Hanol)]

@P16

is the correct behavior to default to the most relevant time period, even if /top is selected manually?

Yes, that is correct.

@P16

are you still open to suggestions for the Top sorting criteria, as the original topic has closed:

Sure, I’ve re-opened the topic.